Allow launching file-based apps via dnx - #132008
Draft
jjonescz wants to merge 1 commit into
Draft
Conversation
|
Azure Pipelines: Successfully started running 3 pipeline(s). 13 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run. |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the dnx dispatchers shipped by the installer so that when the first argument looks like a file path and points to a .cs file (or a file with a #! shebang), dnx routes execution to dotnet run --file-mode instead of treating it as a tool invocation.
Changes:
- Add file-based app detection (path + exists + not directory +
.csor shebang) to the Unixdnxscript. - Add equivalent file-based app detection to
dnx.cmdand route todotnet run --file-modewith a preserved working directory.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| src/installer/pkg/sfx/installers/dnx.cmd | Adds Windows dispatcher logic to detect file paths and run them via dotnet run --file-mode. |
| src/installer/pkg/sfx/installers/dnx | Adds Unix dispatcher logic to detect file paths and run them via dotnet run --file-mode. |
Comment on lines
+35
to
+43
| if [ "$IS_FILE_BASED_APP" = true ]; then | ||
| DNX_WORKING_DIRECTORY="$PWD" | ||
|
|
||
| if ! cd "$(dirname "$DNX_FILE")"; then | ||
| exit 1 | ||
| fi | ||
|
|
||
| exec "$DOTNET" run --file-mode --working-directory "$DNX_WORKING_DIRECTORY" -- "$@" | ||
| fi |
Comment on lines
+35
to
+40
| :run_file | ||
| set "DNX_WORKING_DIRECTORY=%CD%" | ||
| pushd "%~dp1" || exit /b 1 | ||
|
|
||
| "%DOTNET%" run --file-mode --working-directory "%DNX_WORKING_DIRECTORY%" -- %* | ||
| set "EXIT_CODE=%ERRORLEVEL%" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SDK counterpart: dotnet/sdk#55676