Add NativeAOT WebAssembly object writer - #132032
Draft
jtschuster wants to merge 13 commits into
Draft
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
|
Azure Pipelines: Successfully started running 6 pipeline(s). 10 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run. |
Contributor
|
Tagging subscribers to this area: @agocke, @dotnet/ilc-contrib |
jkotas
reviewed
Aug 8, 2026
| assert(helperFunction.accessType == IAT_PVALUE); | ||
| GetEmitter()->emitAddressConstant(helperFunction.addr); | ||
| GetEmitter()->emitIns_I(INS_I_load, EA_PTRSIZE, 0); | ||
| if (helperFunction.accessType != IAT_VALUE) |
Member
There was a problem hiding this comment.
PEP-specific logic should be gated by JitFlags::JIT_FLAG_PORTABLE_ENTRY_POINTS check
jkotas
reviewed
Aug 8, 2026
| assert(call->gtControlExpr != nullptr); | ||
| LIR::Use callTargetUse(BlockRange(), &call->gtControlExpr, call); | ||
| GenTree* callTargetForArg; | ||
| if (call->gtControlExpr != nullptr) |
Member
There was a problem hiding this comment.
The method is called LowerPEPCall. It is odd to overload it to lower non-PEP calls.
This was referenced Aug 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Stacked on #131778.
Validation
dotnet build src/coreclr/tools/aot/ILCompiler/ILCompiler.csproj --no-restorereproZero.objwith the rebuilt ILCompilerwasm-validate --enable-tail-call --enable-exceptions artifacts/bin/reproZero/wasm/Debug/reproZero.objgit diff --checkNote
This pull request description was generated with GitHub Copilot.