Enable packed UTF-16 search on ARM64 - #132901
Closed
EgorBo wants to merge 1 commit into
Closed
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Member
Author
|
@EgorBot -macos_arm -linux_arm -aws_graviton5 using BenchmarkDotNet.Attributes;
using BenchmarkDotNet.Running;
BenchmarkSwitcher.FromAssembly(typeof(PackedUtf16Search).Assembly).Run(args);
public class PackedUtf16Search
{
private string _absent = null!;
private string _late = null!;
[Params(64, 511, 512, 1024, 4096)]
public int Length { get; set; }
[GlobalSetup]
public void Setup()
{
_absent = new string('a', Length);
_late = string.Concat(new string('a', Length - 1), "z");
}
[Benchmark]
public int IndexOfAbsent() => _absent.AsSpan().IndexOf('z');
[Benchmark]
public int IndexOfLate() => _late.AsSpan().IndexOf('z');
[Benchmark]
public int IndexOfRangeAbsent() =>
_absent.AsSpan().IndexOfAnyInRange('x', 'z');
}Note This benchmark comment was generated by GitHub Copilot. |
|
Azure Pipelines: Successfully started running 3 pipeline(s). 13 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run. |
Contributor
|
Tagging subscribers to this area: @dotnet/area-system-buffers |
Member
Author
|
@MihaZupan this is mostly AI slop, but it seems to improve performance for real-world uses. Can you take over when you have time? We need this for arm64 customers. |
Member
|
I ripped it out because it regressed early exits (i.e. Regex) benchmarks. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[Experiment for EgorBot]
Enables packed UTF-16 search on ARM64 for long inputs.
Note
This description was generated by GitHub Copilot.