[release/11.0] Improve PemEncoding.TryFind perf with degenerate inputs - #133249
Merged
Conversation
Rather than seeking for the correct PostEB, just ask if the next hyphen is the PostEB. If not, we can bypass the IsValidBase64 checks.
|
Azure Pipelines: Successfully started running 3 pipeline(s). 13 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run. |
Contributor
|
Tagging subscribers to this area: @bartonjs, @vcsjones, @dotnet/area-system-security |
bartonjs
approved these changes
Sep 4, 2026
This was referenced Sep 4, 2026
Member
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #133137 to release/11.0
/cc @bartonjs
Customer Impact
When TryFind is given degenerate input, it wastes a lot of CPU time realizing that "-----" is not valid Base64.
Regression
Testing
Existing tests say that the new algorithm does not regress functionality, and the new test shows that degenerate inputs are handled well over 10x faster.
Risk
Low, due to test coverage.