Skip to content

JIT: Preserve SIMD operand evaluation and ordering #133776

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
tannergooding wants to merge 3 commits into
base: main
Choose a base branch
from
Open

JIT: Preserve SIMD operand evaluation and ordering #133776

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7b547db
Preserve SIMD operand evaluation and ordering
tannergooding Sep 12, 2026
c306248
Preserve operand order through SIMD intrinsic expansion
tannergooding Sep 12, 2026
f219cc7
Merge branch 'main' into tannergooding-investigate-nan-min-max-folding
tannergooding Sep 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 14 additions & 9 deletions src/coreclr/jit/compiler.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3770,13 +3770,13 @@ class Compiler
var_types type, GenTree* op1, var_types simdBaseType, unsigned simdSize);

GenTree* gtNewSimdStoreNode(
GenTree* op1, GenTree* op2, var_types simdBaseType, unsigned simdSize);
GenTree* op1, GenTree* op2, var_types simdBaseType, unsigned simdSize, bool reverseOps = false);

GenTree* gtNewSimdStoreAlignedNode(
GenTree* op1, GenTree* op2, var_types simdBaseType, unsigned simdSize);
GenTree* op1, GenTree* op2, var_types simdBaseType, unsigned simdSize, bool reverseOps = false);

GenTree* gtNewSimdStoreNonTemporalNode(
GenTree* op1, GenTree* op2, var_types simdBaseType, unsigned simdSize);
GenTree* op1, GenTree* op2, var_types simdBaseType, unsigned simdSize, bool reverseOps = false);

GenTree* gtNewSimdSumNode(
var_types type, GenTree* op1, var_types simdBaseType, unsigned simdSize);
Expand Down Expand Up @@ -3918,18 +3918,23 @@ class Compiler
return gtNewLoadValueNode(type, nullptr, addr, indirFlags);
}

GenTree* gtNewStoreValueNode(
var_types type, ClassLayout* layout, GenTree* addr, GenTree* value, GenTreeFlags indirFlags = GTF_EMPTY);
GenTree* gtNewStoreValueNode(var_types type,
ClassLayout* layout,
GenTree* addr,
GenTree* value,
GenTreeFlags indirFlags = GTF_EMPTY,
bool reverseOps = false);

GenTree* gtNewStoreValueNode(
ClassLayout* layout, GenTree* addr, GenTree* value, GenTreeFlags indirFlags = GTF_EMPTY)
ClassLayout* layout, GenTree* addr, GenTree* value, GenTreeFlags indirFlags = GTF_EMPTY, bool reverseOps = false)
{
return gtNewStoreValueNode(layout->GetType(), layout, addr, value, indirFlags);
return gtNewStoreValueNode(layout->GetType(), layout, addr, value, indirFlags, reverseOps);
}

GenTree* gtNewStoreValueNode(var_types type, GenTree* addr, GenTree* value, GenTreeFlags indirFlags = GTF_EMPTY)
GenTree* gtNewStoreValueNode(
var_types type, GenTree* addr, GenTree* value, GenTreeFlags indirFlags = GTF_EMPTY, bool reverseOps = false)
{
return gtNewStoreValueNode(type, nullptr, addr, value, indirFlags);
return gtNewStoreValueNode(type, nullptr, addr, value, indirFlags, reverseOps);
}

GenTree* gtNewNullCheck(GenTree* addr);
Expand Down
Loading
Loading