Hardcode path to ICU on macOS by akoeplinger · Pull Request #39833 · dotnet/runtime

akoeplinger · 2020-07-23T11:42:05Z

For some reason the path ends up being /Applications/Xcode_11.3.1.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.15.sdk/usr/lib/libicucore.tbd instead of the expected /usr/lib/libicucore.dylib recently on the build machines.

Fixes https://github.com/dotnet/core-eng/issues/10304

EDIT:

To sum up the findings, this is because of the recent cmake upgrade to 3.18 that got pushed to brew with Homebrew/homebrew-core@7927380.

A build that ran 8hours ago (presumably with cmake 3.17.2) still got the expected /usr/lib/libicucore.dylib, a build from 4hours ago got the Xcode path.

ghost · 2020-07-23T11:42:11Z

Tagging subscribers to this area: @tarekgh, @safern, @krwq
See info in area-owners.md if you want to be subscribed.

ViktorHofer

Thanks 👍 👍 👍

am11 · 2020-07-23T12:12:45Z

                return()
            endif()
-            add_definitions(-DOSX_ICU_LIBRARY_PATH=\"${ICUCORE}\")
+            add_definitions(-DOSX_ICU_LIBRARY_PATH=\"/usr/lib/libicucore.dylib\")


nit: does setting CMAKE_FIND_LIBRARY_SUFFIXES=.dylib before the introspection line above (find_library) and unsetting it after the introspection works? That will save us using the hard-coded path.

e.g.

runtime/src/libraries/Native/Unix/System.Security.Cryptography.Native/CMakeLists.txt

Lines 11 to 13 in 827a523

if(CMAKE_STATIC_LIB_LINK)

set(CMAKE_FIND_LIBRARY_SUFFIXES .a)

endif(CMAKE_STATIC_LIB_LINK)

let's do that in a follow-up PR to unblock CI.

it might, but I see no reason why we should not use the hardcoded path since that is where ICU will always be on macOS.

That defeats the purpose of using find_library (the call above). :)

Is CMAKE_REQUIRED_LIBRARIES setting to libicucore.tbd considered ok? maybe we need to change that as well; .tbd is a metadata (YAML) file.

Even better, if we could avoid introducing more hardcoded paths using set(CMAKE_FIND_LIBRARY_SUFFIXES .dylib), it will at least keep it consistent with other usages of find_* macros (under platform conditions or platform specific cmake files), IMHO. e.g. in theory, someone can build libicu locally on macOS (for experiments) and have it installed in other place present in PATH.

doesn't seem to be needed though, will send a PR to remove it ;)

Perhaps this is what you're discussing here, but from https://gitlab.kitware.com/cmake/cmake/-/issues/21007

The .tbd files in the SDK are the preferred way to link to system libraries on macOS. This is in preparation for macOS 11 where the /usr/lib/*.dylib files do not even exist on disk.

Is it correct that /usr/lib/libicucore.dylib does not exist on Big Sur? If so will this change break there?

cc @ViktorHofer

If this doesn't exist in Big Sur I will hit it soon as I will be fixing: #39583

So if that's the case I will also fix this to work on Big Sur.

@danmosemsft @safern I commented on the cmake gitlab issue, but copying here:

I checked on a macOS 11 system and the file is indeed not on disk but you can apparently still load it via dlopen() so we should still be able to use it.

They probably do some tricks in the dynamic loader to allow loading libicucore.dylib even though it doesn't exist at that location on disk. We don't know whether Apple will keep that or remove at some later point though.

akoeplinger · 2020-07-23T12:16:55Z

To sum up the findings, we're 99% sure this is because of the recent cmake upgrade to 3.18 that got pushed to brew with Homebrew/homebrew-core@7927380.

A build that ran 8hours ago (presumably with cmake 3.17.2) still got the expected /usr/lib/libicucore.dylib, a build from 4hours ago got the Xcode path.

Co-authored-by: Alexander Köplinger <alex.koeplinger@outlook.com>

akoeplinger · 2020-07-23T18:33:21Z

Filed an issue with CMake: https://gitlab.kitware.com/cmake/cmake/-/issues/21007

… config Follow-up to dotnet#39833. We don't link against ICU on macOS but load it via `dlopen()` at runtime and compilation uses headers from homebrew. That means `HAVE_SET_MAX_VARIABLE` and `HAVE_UDAT_STANDALONE_SHORTER_WEEKDAYS` will always be defined and we don't need the ICUCORE variable.

… config (#39900) Follow-up to #39833. We don't link against ICU on macOS but load it via `dlopen()` at runtime and compilation uses headers from homebrew. That means `HAVE_SET_MAX_VARIABLE` and `HAVE_UDAT_STANDALONE_SHORTER_WEEKDAYS` will always be defined and we don't need the ICUCORE variable. * PR feedback Co-authored-by: Adeel Mujahid <adeelbm@outlook.com>

… config (dotnet#39900) Follow-up to dotnet#39833. We don't link against ICU on macOS but load it via `dlopen()` at runtime and compilation uses headers from homebrew. That means `HAVE_SET_MAX_VARIABLE` and `HAVE_UDAT_STANDALONE_SHORTER_WEEKDAYS` will always be defined and we don't need the ICUCORE variable. * PR feedback Co-authored-by: Adeel Mujahid <adeelbm@outlook.com>

Hardcode path to ICU on macOS

428c246

Dotnet-GitSync-Bot added the area-System.Globalization label Jul 23, 2020

ViktorHofer approved these changes Jul 23, 2020

View reviewed changes

am11 reviewed Jul 23, 2020

View reviewed changes

ViktorHofer merged commit 05f17e3 into dotnet:master Jul 23, 2020

akoeplinger deleted the hardcode-icu branch July 23, 2020 12:15

ViktorHofer pushed a commit to ViktorHofer/runtime that referenced this pull request Jul 23, 2020

Hardcode path to ICU on macOS (dotnet#39833)

c22a6af

ViktorHofer added a commit that referenced this pull request Jul 23, 2020

Hardcode path to ICU on macOS (#39833) (#39834)

d555ad3

Co-authored-by: Alexander Köplinger <alex.koeplinger@outlook.com>

tarekgh mentioned this pull request Jul 23, 2020

Fix Half comparison #39773

Merged

danmoseley added the os-macos-bigsur (macOS11) label Jul 23, 2020

akoeplinger mentioned this pull request Jul 24, 2020

Remove setting ICUCORE for macOS in System.Globalization.Native CMake config #39900

Merged

This was referenced Jul 30, 2020

macOS PR validation smoke-test failure: libicu not installed/detected in smoke-test dotnet/source-build#1685

Closed

Run "git init" when .git doesn't exist to help GitHub source zip/tar.gz builds dotnet/source-build#1695

Merged

Jacksondr5 pushed a commit to Jacksondr5/runtime that referenced this pull request Aug 10, 2020

Hardcode path to ICU on macOS (dotnet#39833)

ad3952b

karelz added this to the 5.0.0 milestone Aug 18, 2020

ghost locked as resolved and limited conversation to collaborators Dec 8, 2020

	if(CMAKE_STATIC_LIB_LINK)
	set(CMAKE_FIND_LIBRARY_SUFFIXES .a)
	endif(CMAKE_STATIC_LIB_LINK)

Uh oh!

Conversation

akoeplinger commented Jul 23, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ghost commented Jul 23, 2020

Uh oh!

ViktorHofer left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

akoeplinger commented Jul 23, 2020

Uh oh!

akoeplinger commented Jul 23, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

akoeplinger commented Jul 23, 2020 •

edited

Loading