Fix releasing of file handle in binder tracing - #39974
Merged
Merged
Conversation
|
Tagging subscribers to this area: @vitek-karas, @agocke |
vitek-karas
approved these changes
Jul 27, 2020
janvorli
approved these changes
Jul 27, 2020
janvorli
left a comment
janvorli
left a comment
Member
There was a problem hiding this comment.
LGTM, I have verified that it fixes the original issue.
This reverts commit 581d68d.
Member
Author
|
Formatting failure is unrelated to these changes and being hit in other runs as well. |
Jacksondr5
pushed a commit
to Jacksondr5/runtime
that referenced
this pull request
Aug 10, 2020
ghost
locked as resolved and limited conversation to collaborators
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AssemblyBindOperationwas only releasing the file handle if binder tracing was on...Fix #39609
cc @vitek-karas @janvorli
Not sure if there's a good / reliable way to add a test for this.