[wasm][debugger] Try to enable debugger tests#42190
Closed
radical wants to merge 2 commits intodotnet:masterfrom
Closed
[wasm][debugger] Try to enable debugger tests#42190radical wants to merge 2 commits intodotnet:masterfrom
radical wants to merge 2 commits intodotnet:masterfrom
Conversation
radical
added
the
NO-MERGE
|
Tagging subscribers to this area: @thaystg |
Member
Author
|
The first commit is useful by itself too. |
With this, you can run tests with just: `dotnet test DebuggerTestSuite`.
Changes:
- Fix `DebuggerTestSuite.csproj` to work with `dotnet test`
- and add a dependency on debugger-test project
- And bake the settings being used for debugger-test in the csproj
itself
- eg. Configuration=Debug (we want the pdbs)
- RuntimeConfiguration defaults to Release, same as what the
Makefile did
- build debugger-tests in artifacts dir
- And instead of `TEST_SUITE_PATH`, determine the debugger-tests path
based on the testsuite itself.
- We can then remove `build-debugger-test-app`
lewing
force-pushed
the
wasm-enable-debugger-tests
branch
from
b99ecbc to
3c01c65
Compare
Member
|
@radical I resolved the conflict here but there still seems to be issues? |
Member
Author
|
Yep, looking into that. |
Member
|
@radical the debugger project changes are in, should we update this or close it? I'm not clear where we are with running the debugger tests in CI |
Member
Author
|
Yeah, we can close this. I should have a PR for running the tests on CI next week. |
ghost
locked as resolved and limited conversation to collaborators
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.