[wasm][bindings] Fix an api regression introduced in #42486#42658
Merged
lewing merged 2 commits intodotnet:masterfrom Sep 24, 2020
Merged
[wasm][bindings] Fix an api regression introduced in #42486#42658lewing merged 2 commits intodotnet:masterfrom
lewing merged 2 commits intodotnet:masterfrom
Conversation
lewing
changed the title
lewing
changed the title
lewing
added
area-System.Runtime.InteropServices.JavaScript
arch-wasm
radical
reviewed
Sep 24, 2020
a number it is Co-authored-by: Ankit Jain <radical@gmail.com>
radical
approved these changes
Sep 24, 2020
kg
approved these changes
Sep 24, 2020
kg
added a commit
to kg/runtime
that referenced
this pull request
Sep 24, 2020
marek-safar
pushed a commit
that referenced
this pull request
Sep 29, 2020
marek-safar
pushed a commit
that referenced
this pull request
Oct 9, 2020
ghost
locked as resolved and limited conversation to collaborators
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Return null from js_string_to_mono_string when passed null, like it did prior to #42486
fixed broken wasm debugger tests that need to run in CI #42190