check for PhysicalFileProvider

[stefannikolei]

• check that it is not a subclass of PhysicalFileProvider
  fix Json Configuration custom IFileProvider stopped working for .NET 5.0 #47455

[ghost]

Tagging subscribers to this area: @maryamariyan
See info in area-owners.md if you want to be subscribed.

Issue Details

---

• check that it is not a subclass of PhysicalFileProvider
  fix Json Configuration custom IFileProvider stopped working for .NET 5.0 #47455

Author:	stefannikolei
Assignees:	-
Labels:	area-Extensions-Configuration
Milestone:	-

[maryamariyan]

@stefannikolei thanks for the PR, could you also please add a test for this?

[maryamariyan]

The PR change seems fine, @stefannikolei could you please also add a tests for this fix?

[maryamariyan]

@mcm-ham (who reported the issue) if you have a small repro code that would help with preparing a test case here.

[eerhardt]

Couldn't this just be

Suggested change

	&& provider is PhysicalFileProvider && !provider.GetType().IsSubclassOf(typeof(PhysicalFileProvider)))
	&& provider?.GetType() == typeof(PhysicalFileProvider))

Also - would be great to add a comment here why we are doing this.

[davidfowl]

Can we do this check once in the constructor

[safern]

@stefannikolei thanks for your PR, do you plan on addressing the feedback and adding a test case for this?

[stefannikolei]

thanks for your PR, do you plan on addressing the feedback and adding a test case for this?
@safern

Sorry missed the feedback. Gonna look at it.
Was waiting for @mcm-ham to hopefully deliver some repro code to make the test easier.

[maryamariyan]

Closing this PR. @stefannikolei this is a good change, you could create a new PR if you plan on addressing the feedback