[wasm][aot] Disable failing AOT tests, to get a green build by radical · Pull Request #51724 · dotnet/runtime

radical · 2021-04-23T02:34:50Z

this will allow tracking new failures too
uses new PlatformDetection.IsMonoAOT, and PlatformDetection.IsBuiltWithAggressiveTrimming

…Unsafe.Tests

… AOT

…out with AOT

ghost · 2021-04-23T02:34:56Z

Tagging subscribers to 'arch-wasm': @lewing
See info in area-owners.md if you want to be subscribed.

Issue Details

this will allow tracking new failures too

Author:	radical
Assignees:	-
Labels:	`arch-wasm`, `area-Build-mono`
Milestone:	-

radical · 2021-04-23T02:35:10Z

cc @SamMonoRT

lewing · 2021-04-23T03:00:13Z

Won't the ActiveIssue attribute disable them on the interpreter too?

SamMonoRT · 2021-04-23T14:15:20Z

Won't the ActiveIssue attribute disable them on the interpreter too?

yes, they actually might for Library tests

@naricc is trying to clear that out via #51522 for Runtime tests.

.. the failing aot tests.

…ed by dotnet#51747

…a.Tests.TagToTokenTests.ValidateTagToTokenConversion ``` [07:29:18] fail: [FAIL] System.Reflection.Metadata.Tests.TagToTokenTests.ValidateTagToTokenConversion [07:29:18] info: System.NullReferenceException : Object reference not set to an instance of an object. [07:29:18] info: at System.Reflection.Metadata.Tests.TagToTokenTests.<>c__DisplayClass1_0.<GetTags>b__3() [07:29:18] info: at System.Reflection.Metadata.Tests.TagToTokenTests.ValidateTagToTokenConversion() [07:29:18] info: at System.Reflection.RuntimeMethodInfo.Invoke(Object obj, BindingFlags invokeAttr, Binder binder, Object[] parameters, CultureInfo culture) ``` Issue: dotnet#50714

` error : FilesToIncludeInFileSystem file '/Users/radical/dev/runtime/artifacts/bin/System.Reflection.Tests/net6.0-Release/browser-wasm/publish/System.Reflection.Tests.pdb' not found`

`TestAssembly` gets trimmed causing errors like: ``` fail: [FAIL] System.Reflection.Tests.AssemblyTests.CreateInstance_Invalid(typeName: null, exceptionType: typeof(System.ArgumentNullException)) info: System.IO.FileNotFoundException : Could not find file '/TestAssembly.dll'. ```

…veTrimming to true Address review feedback from lewing

- since we don't run with fullaot at all, both interpreter and aot checks should be true, when using aot-interpreter mode

lewing

👍

ghost · 2021-04-27T01:55:34Z

Hello @radical!

Because this pull request has the auto-merge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (`@msftbot`) and give me an instruction to get started! Learn more here.

…ion.cs

radical · 2021-04-27T05:52:07Z

runtime-staging (Build windows x64 Release AllSubsets_Mono) failing due to nuget errors, unrelated to this PR:

.dotnet\sdk\6.0.100-preview.2.21155.3\NuGet.RestoreEx.targets(19,5): error : (NETCORE_ENGINEERING_TELEMETRY=Restore) Failed to download package 'System.Reflection.Emit.Lightweight.4.3.0' from 'https://pkgs.dev.azure.com/dnceng/9ee6d478-d288-47f7-aacc-f6e6d082ae6d/_packaging/45bacae2-5efb-47c8-91e5-8ec20c22b4f8/nuget/v3/flat2/system.reflection.emit.lightweight/4.3.0/system.reflection.emit.lightweight.4.3.0.nupkg'.
The SSL connection could not be established, see inner exception.
  Unable to read data from the transport connection: An existing conne

radical added 13 commits April 22, 2021 21:51

[wasm] Disable 2 failing Common.Tests for AOT

8cd9d39

[wasm][aot] Disable failing System.Collections.Tests for AOT

c54a26e

[wasm][aot] Disable failing System.Diagnostics.StackTrace.Tests for AOT

e57aee1

[wasm][aot] Disable failing System.Diagnostics.TraceSource.Tests for AOT

896932f

[wasm][aot] Disable 3 failing tests for System.IO.Pipelines.Tests

2a9ae41

[wasm][aot] Disable failing test for System.Memory.Tests

c828739

[wasm][aot] Disable failing test for System.Runtime.CompilerServices.…

b83375f

…Unsafe.Tests

[wasm][aot] Disable System.Text.Encodings.Web.Tests due to crash with…

d3271da

… AOT

[wasm][aot] Disable System.Threading.Tasks.Parallel.Tests due to time…

42fbdfc

…out with AOT

[wasm][aot] Disable failing tests for System.Threading.Tasks.Tests

7cde565

[wasm][aot] Disable failing tests for System.Transactions.Local.Tests

6cf3e7a

[wasm][aot] Disable System.Linq.Tests due to crash with AOT

f9efb63

[wasm][aot] Disable failing tests for System.CodeDom.Tests

9f37d69

radical added arch-wasm WebAssembly architecture area-Build-mono labels Apr 23, 2021

radical requested review from akoeplinger, lewing and vargaz April 23, 2021 02:34

radical mentioned this pull request Apr 23, 2021

Enable use of RuntimeVariant to exclude runtime tests #51522

Merged

radical added 2 commits April 23, 2021 20:20

[wasm] Add new PlatformDetection.IsBrowserAOT, and use that to disable

c9f391d

.. the failing aot tests.

Merge remote-tracking branch 'origin/main' into wasm-aot-green

33b763c

lewing reviewed Apr 24, 2021

View reviewed changes

Comment thread eng/testing/tests.wasm.targets Outdated

Add PlatformDetection.IsMonoAOT, and update tests to use that

8fb3a6f

radical requested a review from marek-safar as a code owner April 24, 2021 05:46

radical added 2 commits April 24, 2021 01:51

[wasm] Enable System.Runtime.CompilerServices.UnsafeTests.NullRef fix…

a151eac

…ed by dotnet#51747

Merge remote-tracking branch 'origin/main' into wasm-aot-green

1a04526

radical added 5 commits April 24, 2021 02:39

Fix missed changes

88e76fe

[wasm] Disable individual tests failing with trimming

8658525

[wasm] Fix test build errors in System.Reflection.Tests with trimming

73301a1

` error : FilesToIncludeInFileSystem file '/Users/radical/dev/runtime/artifacts/bin/System.Reflection.Tests/net6.0-Release/browser-wasm/publish/System.Reflection.Tests.pdb' not found`

radical requested a review from lewing April 26, 2021 17:48

lewing reviewed Apr 26, 2021

View reviewed changes

Comment thread src/libraries/Common/tests/TestUtilities/System/PlatformDetection.cs Outdated

radical added 2 commits April 26, 2021 16:56

Use linker substitutions to set PlatformDetection.IsBuiltWithAggressi…

e3530bd

…veTrimming to true Address review feedback from lewing

Use TestUtilities substitutions only if AggressiveTrimming is enabled

606c703

lewing reviewed Apr 27, 2021

View reviewed changes

Comment thread src/libraries/Common/tests/TestUtilities/System/PlatformDetection.cs Outdated

radical added 2 commits April 26, 2021 21:48

[wasm] Fix PlatformDetection.IsMonoAOT

6f1baf6

- since we don't run with fullaot at all, both interpreter and aot checks should be true, when using aot-interpreter mode

Merge remote-tracking branch 'origin/main' into wasm-aot-green

f448a2e

lewing approved these changes Apr 27, 2021

View reviewed changes

radical added the auto-merge label Apr 27, 2021

lewing reviewed Apr 27, 2021

View reviewed changes

Comment thread src/libraries/Common/tests/TestUtilities/System/PlatformDetection.cs Outdated

lewing added 2 commits April 26, 2021 21:20

Update src/libraries/Common/tests/TestUtilities/System/PlatformDetect…

e2b7ea9

…ion.cs

Update PlatformDetection.cs

5196757

radical merged commit fa7c6a9 into dotnet:main Apr 27, 2021

radical deleted the wasm-aot-green branch April 27, 2021 05:55

karelz modified the milestones: 5.0.x, 6.0.0 May 20, 2021

ghost locked as resolved and limited conversation to collaborators Jun 19, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[wasm][aot] Disable failing AOT tests, to get a green build#51724

[wasm][aot] Disable failing AOT tests, to get a green build#51724
radical merged 29 commits into
dotnet:mainfrom
radical:wasm-aot-green

radical commented Apr 23, 2021 •

edited

Loading

Uh oh!

ghost commented Apr 23, 2021

Uh oh!

radical commented Apr 23, 2021

Uh oh!

lewing commented Apr 23, 2021

Uh oh!

SamMonoRT commented Apr 23, 2021 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

Uh oh!

lewing left a comment

Uh oh!

ghost commented Apr 27, 2021

Uh oh!

Uh oh!

radical commented Apr 27, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Uh oh!

Conversation

radical commented Apr 23, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ghost commented Apr 23, 2021

Uh oh!

radical commented Apr 23, 2021

Uh oh!

lewing commented Apr 23, 2021

Uh oh!

SamMonoRT commented Apr 23, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

lewing left a comment

Choose a reason for hiding this comment

Uh oh!

ghost commented Apr 27, 2021

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

Uh oh!

Uh oh!

radical commented Apr 27, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

radical commented Apr 23, 2021 •

edited

Loading

SamMonoRT commented Apr 23, 2021 •

edited

Loading

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (`@msftbot`) and give me an instruction to get started! Learn more here.