Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Remove Hot Reload support from dotnet watch (#22217)" #22262

Merged
merged 4 commits into from Oct 23, 2021

Conversation

3nprob
Copy link

@3nprob 3nprob commented Oct 22, 2021

This reverts #22217.

@dotnet-issue-labeler
Copy link

I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label.

@dnfadmin
Copy link

dnfadmin commented Oct 22, 2021

CLA assistant check
All CLA requirements met.

@3nprob 3nprob force-pushed the revert-remove-reload-watch branch 2 times, most recently from c51100e to 56459be Compare October 22, 2021 05:11
@3nprob
Copy link
Author

3nprob commented Oct 22, 2021

FYI it looks like there's a lot of community interest in this functionality even in its current state @pranavkm (thanks for your work on this!) @mmitche @mkArtakMSFT

Comment on lines +104 to +107
<Dependency Name="Microsoft.CodeAnalysis.CSharp.Features" Version="4.0.0-6.21519.19">
<Uri>https://github.com/dotnet/roslyn</Uri>
<Sha>3a0930fe6990248c848db2f1e323d7dd2052005b</Sha>
</Dependency>

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there any information about the "trouble for source-build"?

Copy link

@0rvar 0rvar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

@matkoch matkoch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I approve. Lol :D

@ShreyasJejurkar
Copy link

ShreyasJejurkar commented Oct 22, 2021

Please someone decode or hack the HTML on this page and get the merge button and merge it before November!
Thanks.

Edit - This is the PR that is truly going to decide .NET is really an OSS or not!

Put seatbelts guys!

Update (After merged) - Yessss .NET is OSS!
Thanks everyone for efforts!

@stack72
Copy link

stack72 commented Oct 22, 2021

🍿🍿 to see if the dotnet SDK is truly open source....

Copy link

@redsquare redsquare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to go

Copy link
Member

@Happypig375 Happypig375 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I broke the approve chain!

Copy link

@slang25 slang25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 😃

@tanveerbadar
Copy link

LGTM

Copy link
Member

@ghuntley ghuntley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Legend

@azhe403
Copy link

azhe403 commented Oct 25, 2021

LGTM!

@jifbrodeur
Copy link

jifbrodeur commented Oct 25, 2021

Please Microsoft Bring this back!

@Breadleyg
Copy link

👍

@ChrisE217
Copy link

Yeooooooo

@kefengwei
Copy link

👍

@trolley813
Copy link

Microsoft has really "hot-reloaded" their decision.

@pm4rcin
Copy link

pm4rcin commented Oct 25, 2021

I enjoy this move, thx. Thx for all Contributors of Open Source projects!
I personally use Net Core with Visual Studio Code. I use Net Core CLI. Work great, cross-platform, open source.. Thx !!

So am I, much to my team's amazement, but I feel that vscode is the best software I could think of for general development. I tried VS and Rider, and something simple didn't click. So after eight years with VS, I switched to vscode and had my best three years in code development.

Well in general you could achieve the same effects with vscode but it requires to install some plugins and configure it properly but then it could be better mostly in terms of resource usage and speed. :)

@4oo4
Copy link

4oo4 commented Oct 25, 2021

Microsoft's actual .Net developers can see through this too:

https://pastebin.com/RF6015kv

@Almusamim
Copy link

@3nprob Viva la revolucion ✌️

@deividfortuna
Copy link

deividfortuna commented Oct 25, 2021

👍🏻

@liuhll
Copy link

liuhll commented Oct 26, 2021

Microsoft shouldn't mess around

@unspecd
Copy link

unspecd commented Oct 26, 2021

Open-before-closing software.

@Pinox
Copy link

Pinox commented Oct 26, 2021

To those involved in reverting , thank you. Read on some blog the reason for this is that VS should have this feature at the expense of the SDK and various other company politics at play.

Strange thing is I use dotnet watch all the time with VS ( I do not use other code editor). So dotnet watch is hugely complimentary for my workflow with VS and it makes no sense to remove this feature as it will make me less productive in VS.

Whoever the exec that took this decision do not understand modern software development. If this is the same exec that decided against upgrading UWP to .NET 5/6 then I would argue it's time that this person takes some well deserved garden leave.

@RaymondTracer
Copy link

Talk about out-of-touch, what an embarrassment. Glad this was reverted, good job everyone!

@Happypig375
Copy link
Member

Whoever the exec that took this decision do not understand modern software development. If this is the same exec that decided against upgrading UWP to .NET 5/6 then I would argue it's time that this person takes some well deserved garden leave.

Anyone remember VB.NET? It's dead now. +1 kill by Microsoft

@bbondarets
Copy link

This is awesome. 🔥

@erenkulaksiz
Copy link

Whoever the exec that took this decision do not understand modern software development. If this is the same exec that decided against upgrading UWP to .NET 5/6 then I would argue it's time that this person takes some well deserved garden leave.

Anyone remember VB.NET? It's dead now. +1 kill by Microsoft

I remember me doing calculator on windows forms with vb.net back in the days

@crozone
Copy link

crozone commented Oct 29, 2021

Whoever the exec that took this decision do not understand modern software development. If this is the same exec that decided against upgrading UWP to .NET 5/6 then I would argue it's time that this person takes some well deserved garden leave.

Anyone remember VB.NET? It's dead now. +1 kill by Microsoft

VB.NET was a mercy killing.

@AraHaan
Copy link
Member

AraHaan commented Oct 29, 2021

Agreed after years of no updates to the VB.Net language, it was begging to be released from it’s pain.

@Seirdy
Copy link

Seirdy commented Nov 1, 2021

We need to push for the .NET Foundation to be fully independent from any companies (except monetarily and maintaining wise) but without any ability to force their company plans onto the open source aspects of the .NET Platform (excluding Visual Studio Integrations or roslyn). Meaning once they add something to the .NET SDK, it should be owned by the .NET Foundation (and not Microsoft) and so then Microsoft cannot remove it without approval from the community and members of the foundation so that way they do not accidentally remove something that will have a lot of push back from both the community and the foundation members alike.

This alone is not enough. Developers shouldn't have to sign away copyright under the existing CLA: signing off on the DCO would be a much better alternative that can help minimize the damage of locking up previously free features. This is why I'm generally hesitant to contribute to any project that requires signing a CLA.

@AraHaan
Copy link
Member

AraHaan commented Nov 1, 2021

I agree, however some people do not care if they sign off on their own copyright if all they care about is the project being able to continue on and be maintained even after their death. Besides any of us can be developing 1 second and die the next by some unknown cause.

Copy link

@newpost newpost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good job

@ghuntley
Copy link
Member

ghuntley commented Nov 2, 2021

Hey folks,

Back in 2014, .NET was open-sourced. It’s now 2021, dotnet/core#505 was opened in 2017. Last week the .NET SDK had code ripped out of it by a CVP to sell more Visual Studio licenses.

"Product managers don't have the authority to yank something in a release candidate with a go-live license :)" - Phillip Carter

It's time to increase the heat and awareness of dotnet/core#505 - the singular thing that stands in the way of .NET completing its transition to an open programming language.

Introducing https://isdotnetopen.com/

This Ballmeresq cold war with tooling vendors only harms the ecosystem. The more people who can use .NET and that are attracted to .NET the more Microsoft can sell Azure because there’s great attach rates and uplift between .NET folks and Azure.

".NET, Visual Studio, and Visual Studio Code are all expensive ad campaigns funded by Azure. .NET and Visual Studio have excellent attach rate to Azure" - msft-throwaway

Every marketing activity (omg lost count) Microsoft has done with .NET about rar rar rar “we are open-source” is fundamentally lipstick on a pig if there is no way to debug programs authored in the language. What use is an open-source programming language that can’t be debugged?

@atrauzzi
Copy link

atrauzzi commented Nov 2, 2021

I'm definitely not getting back into Azure, but I will gladly use .NET on Google Cloud and I'm sure the growth and ubiquity of the ecosystem helps them all the same.

So yeah, a fully open source and independent .NET is essential.

(@ghuntley -- feel free to link to my blog post)

@francofgp
Copy link

I'm definitely not getting back into Azure, but I will gladly use .NET on Google Cloud and I'm sure the growth and ubiquity of the ecosystem helps them all the same.

So yeah, a fully open source and independent .NET is essential.

(@ghuntley -- feel free to link to my blog post)

Nice reading

Copy link

@akay akay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@hughesjs
Copy link

Top work getting this reverted guys, really was an own-goal from Microsoft here. This was somehow even worse than excluding Linux from MAUI and pretending its genuinely cross-platform. As excited as I am for .NET 6, this really has undone a lot of the confidence I was starting to get that Stallman era Linux is cancer Microsoft had truly changed...

@thepwrtank18
Copy link

This is usually how it starts. Big company takes away, big company gives back, big company gets applause.

And then after that loop, it starts becoming big company taking away, just without the giving back, but with the applause.

@SHEHEERALIZX
Copy link

We want the hot reload

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment