-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert "Remove Hot Reload support from dotnet watch (#22217)" #22262
Revert "Remove Hot Reload support from dotnet watch (#22217)" #22262
Conversation
I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label. |
c51100e
to
56459be
Compare
FYI it looks like there's a lot of community interest in this functionality even in its current state @pranavkm (thanks for your work on this!) @mmitche @mkArtakMSFT |
<Dependency Name="Microsoft.CodeAnalysis.CSharp.Features" Version="4.0.0-6.21519.19"> | ||
<Uri>https://github.com/dotnet/roslyn</Uri> | ||
<Sha>3a0930fe6990248c848db2f1e323d7dd2052005b</Sha> | ||
</Dependency> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there any information about the "trouble for source-build"?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
56459be
to
6d9b470
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I approve. Lol :D
Please someone decode or hack the HTML on this page and get the merge button and merge it before November! Edit - This is the PR that is truly going to decide .NET is really an OSS or not! Put seatbelts guys! Update (After merged) - Yessss .NET is OSS! |
🍿🍿 to see if the dotnet SDK is truly open source.... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to go
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I broke the approve chain!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me 😃
LGTM |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Legend
LGTM! |
Please Microsoft Bring this back! |
👍 |
Yeooooooo |
👍 |
Microsoft has really "hot-reloaded" their decision. |
Well in general you could achieve the same effects with vscode but it requires to install some plugins and configure it properly but then it could be better mostly in terms of resource usage and speed. :) |
Microsoft's actual .Net developers can see through this too: |
@3nprob Viva la revolucion ✌️ |
👍🏻 |
Microsoft shouldn't mess around |
Open-before-closing software. |
To those involved in reverting , thank you. Read on some blog the reason for this is that VS should have this feature at the expense of the SDK and various other company politics at play. Strange thing is I use dotnet watch all the time with VS ( I do not use other code editor). So dotnet watch is hugely complimentary for my workflow with VS and it makes no sense to remove this feature as it will make me less productive in VS. Whoever the exec that took this decision do not understand modern software development. If this is the same exec that decided against upgrading UWP to .NET 5/6 then I would argue it's time that this person takes some well deserved garden leave. |
Talk about out-of-touch, what an embarrassment. Glad this was reverted, good job everyone! |
Anyone remember VB.NET? It's dead now. +1 kill by Microsoft |
This is awesome. 🔥 |
I remember me doing calculator on windows forms with vb.net back in the days |
VB.NET was a mercy killing. |
Agreed after years of no updates to the VB.Net language, it was begging to be released from it’s pain. |
This alone is not enough. Developers shouldn't have to sign away copyright under the existing CLA: signing off on the DCO would be a much better alternative that can help minimize the damage of locking up previously free features. This is why I'm generally hesitant to contribute to any project that requires signing a CLA. |
I agree, however some people do not care if they sign off on their own copyright if all they care about is the project being able to continue on and be maintained even after their death. Besides any of us can be developing 1 second and die the next by some unknown cause. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good job
Hey folks, Back in 2014, .NET was open-sourced. It’s now 2021, dotnet/core#505 was opened in 2017. Last week the .NET SDK had code ripped out of it by a CVP to sell more Visual Studio licenses.
It's time to increase the heat and awareness of dotnet/core#505 - the singular thing that stands in the way of .NET completing its transition to an open programming language. Introducing https://isdotnetopen.com/ This Ballmeresq cold war with tooling vendors only harms the ecosystem. The more people who can use .NET and that are attracted to .NET the more Microsoft can sell Azure because there’s great attach rates and uplift between .NET folks and Azure.
Every marketing activity (omg lost count) Microsoft has done with .NET about rar rar rar “we are open-source” is fundamentally lipstick on a pig if there is no way to debug programs authored in the language. What use is an open-source programming language that can’t be debugged? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Top work getting this reverted guys, really was an own-goal from Microsoft here. This was somehow even worse than excluding Linux from MAUI and pretending its genuinely cross-platform. As excited as I am for .NET 6, this really has undone a lot of the confidence I was starting to get that Stallman era Linux is cancer Microsoft had truly changed... |
This is usually how it starts. Big company takes away, big company gives back, big company gets applause. And then after that loop, it starts becoming big company taking away, just without the giving back, but with the applause. |
We want the hot reload |
This reverts #22217.