Use netstandard1.3 in our tasks library.#5
Conversation
| <TargetFrameworkVersion>v1.3</TargetFrameworkVersion> | ||
| </PropertyGroup> | ||
| <ItemGroup> | ||
| <None Include="Microsoft.DotNet.Core.Sdk.targets" /> |
There was a problem hiding this comment.
Should this be copied to output?
There was a problem hiding this comment.
Not sure. It needs to get packaged into the .nupkg (which is my next step). That will get figured out then.
|
build.cmd fails with this patch, lots of missing assembly and using references. |
I assume build.cmd will need to call restore before build. Can you try restoring in VS on your machine and then call build.cmd? |
|
I can work on getting an LKG version of the CLI installed during build.cmd, which will then be able to restore. And we can use "dotnet build3", which will build the solution, instead of relying on msbuild being installed on the box. |
|
Yeah, restore fixed it. For that version of .NET, would we have to include it in the repo, or are we going to have to configure Jenkins slaves and microbuild instances with those binaries? |
It will be downloaded "on the fly" |
|
@333fred - how about now? does it build cleanly on your box with my latest change? |
eerhardt
force-pushed
the
UseNetstandard1.3
branch
from
b13e7df to
ad3834f
Compare
|
@eerhardt yep, clean build works just fine now, restoring all packages. |
build.ps1
Outdated
There was a problem hiding this comment.
will the space here throw off the arg parsing when passing it through to msbuild?
There was a problem hiding this comment.
Doesn't appear to on my box. It failed when this wasn't supplied. It passes now.
There was a problem hiding this comment.
I'm not as familiar with PS quoting defaults as bash, thanks for the clarification.
|
|
eerhardt
force-pushed
the
UseNetstandard1.3
branch
from
ad3834f to
8c5a153
Compare
Use netstandard1.3 in our tasks library.
Fixing the MsBuild version in the tasks assembly
Changes include: - Rename 'managed installations' to 'tracked installations' (dotnet#10) - Fix '.metadata' -> 'metadata' folder name (dotnet#18) - Include component type in error/warning messages (dotnet#11) - Remove component spec from runtime update (dotnet#12) - Remove GetInstallations wrapper (dotnet#6) - ScopedMutex throws TimeoutException on failure (dotnet#22) - Make InstallResult.Install non-nullable (dotnet#17) - Remove ComponentFilesExist shortcut (dotnet#19) - Wire up InstallSource enum (dotnet#21) - ListCommand: enum types, narrowed mutex, read-only verify, spacing (dotnet#3,dotnet#4,dotnet#5,#1) - Show global.json path in list output (dotnet#15) - Add doc comments to ListData types (dotnet#7) - Move SourceOption to CommonOptions, remove alias fields (dotnet#9) - Remove ResolveChannelFromGlobalJson test hook wrapper (dotnet#14) - Root 'dotnetup update' updates all components (dotnet#16) - GlobalJsonChannelResolver: support rollForward policy (dotnet#13) - Error when installing to unmanaged dotnet root (dotnet#20) Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Changes include: - UpdateWorkflow.Execute returns non-zero exit code on failure (#1) - InfoCommand JSON output includes InstallSpecs (dotnet#2) - Wire --update-global-json through SdkUpdateCommand to UpdateWorkflow (dotnet#3) - Implement DotnetInstallManager.UpdateGlobalJson using Utf8JsonReader (dotnet#3) - Fix ResolveEntryDestPath to use normalized entry name (dotnet#4) - Fix test: MajorMinor test uses correct channel '9.0' (dotnet#5) - Fix test: LTS assertion checks Major instead of Minor (dotnet#6) - Fix ScopedMutex.Dispose to not leak mutex on ReleaseMutex throw (dotnet#7) - Make CommonOptions fields static readonly (dotnet#9) - Remove unused --no-progress from uninstall parsers (dotnet#10) - GarbageCollector catches Exception instead of just IOException (dotnet#11) - Capitalize 'SDK' in SdkCommandParser description (dotnet#12) - Eliminate redundant manifest reads in InstallerOrchestratorSingleton (dotnet#13) - Fix STS test error message to say 'major' not 'minor' (dotnet#14) - Make DotnetupUtilities.ExeSuffix readonly (dotnet#16) - Fix FormatBytes to use floating-point with one decimal (dotnet#17) - Remove dead ReleaseManifest variable in DotnetInstaller (dotnet#18) - Make UpdateChannel.Name immutable (dotnet#19) Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
4 participants
I also added the current "Sdk" .props and .targets files from the dotnet/cli repo. We can modify these as we go. Our "Tasks" library will be the first test for these .props and .targets files.