Merge master into release #1410
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merge release into master
* Adding quoteArgs flag * Adding QuoteArgs to PipeConfiguration * Updating Description for QuoteArgs * Fixing typo in description
The `tsc` can be run from already defined NPM script and by this: - no local installation is needed for compiler - the long path for Windows OS command is no longer required Usage: npm run watch > csharp@1.8.0 watch /Users/piotrblazejewicz/git/omnisharp-vscode > tsc -watch -p ./ 3:19:52 PM - Compilation complete. Watching for file changes. ... Thanks!
This commit updates task configuration to use current configuration keys and to limit number of warnings displayed in VSCode itself. Similar one: microsoft/vscode-generator-code#59 Thanks!
Switch from deprecated outDir to outFiles in tasks config
Clarify and shorten watch NPM task description [skip ci]
Add '"' and ':' as trigger characters for project.json completion
Update to 1.9.0-beta1
We were using native 'path.join' when creating paths for VS Code assets (tasks.json, launch.json). On windows this would produce windows style paths. If the assets are checked into source control and used on posix systems, they will break. Posix paths will run perfectly fine on windows, so always use posix paths.
Always use posix paths in asset generation
Merge release to master
Recently github has stopped liking the markdown in debugger.md. This fixes it.
* Adding help text to created launch.json * Converting configuration to be strings + comments Also moving launch.json information from debugger.md to debugger-launchjson.md. This commit adds json-comment in order to parse json strings with comments for testing. * Remove json-comments and update md Removed json-comments to use jsonc-parser. Adding more information to launchjson.md and updating links. * Fixing CR Issues Removing package depedencies. * Fixing URLS
Fixes issue with asset generation message when it isn't required
…launching OmniSharp
Add 'omnisharp.waitForDebugger' option to pass the --debug flag with launching OmniSharp
* Adding in configuration snippets * Adding user filled syntax
* Improve dependancy handling / Linux distro handling #1361 #1323 Changes: 1. Add a setting to control what version of the debugger to use on Linux 2. We no longer automaticially select a debugger on Arch. Instead, we point folks to a web page telling them how to install it. 3. Added logic to the package manager so that it can detect if a package is already installed so it will not be redownloaded. This was needed since I wanted to trigger redownloads in the case that the user added the Linux distro setting. But it seemed like a useful feature anyway for folks on slow internet connections. 4. Moved the install code to its own .ts file * Updates to the changelog * Code review fixes * Restore original whitespace in package.json * Remove 'runtime id' from the install log
Update OmniSharp and add support for running/debugging tests
* Allowing quote args flag to handle pipeProgram Also moved list process command to be written to a temp file and redirected to the pipeProgram. * Fixing syntax * Change bash to sh Fixing syntax since = is for equality in sh. Also tested with Mac -> Linux w/ ZSH * Fixing CR issues * Handle debuggerCommand * Replacing all instances of debuggerCommand in str. * Revert package.json and fix check for command
…test Properly handle quoted arguments when splitting command line arguments from VS Test
Don't create hidden diagnostics
This updates the debugger to the 1.9.2 version. This includes the support needed for unit test support and limited desktop CLR debugging.
This checkin isn't quite complete as it needs to be tested on Mac and Linux, and I need to update debugger packages, but this is the start of adding a new mechanism for sending events from the debugger to the extension for unit testing support.
- Added code to unlink the unix domain socket (in case there is one around from a previous reboot). - I forgot that TypeScript enums don't behave quite like what I wanted. This switches from an enum to a module. - Fixes DebugEventListener to cleanup only once. - Handle errors in DebugEventListener
- Add a bit more logging status - Move when OmniSharp is invoked
Send events from the debugger to unit test code
Consume debugger events and notify OmniSharp
* Returning error on processPick and validate prog child_process.exec will spawn a 32 bit process which C:\Windows\System32\bash.exe will not exist and fail for process picker. Will attempt to try to run C:\Windows\sysnative\bash.exe for process picker. This is not an issue if users just use bash.exe for pipeProgram. * Fixing style * Fixing PR Issues Validating sysnative program before replacing. * Reorganizing conditions
Add recent updates to changelog for 1.9
- Update the changelog - Add link to WSL documentation
gregg-miskelly
approved these changes
Apr 20, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.