docs(ledger): mark the historical "93" suite counts as historical - #168
Conversation
Nine ledger entries state the n64-systemtest failing-assertion count as 93. That was true when each was written, but Phase 5 dropped it to 90, and the correction lives ~1200 lines further down under "Measured n64-systemtest impact" — so a reader (or a review bot) landing on R-8/R-11/R-16/R-17 sees a stale number with no indication it has moved. It has been flagged repeatedly. The ledger's stated policy is to leave those notes as-is, "historical, per the ledger's immutability discipline", so this does NOT rewrite them. Each stale mention now carries a short parenthetical saying it is the count as at that entry, that `docs/STATUS.md` is authoritative, and that the note below corrected it to 90. The claims themselves are untouched. This is the decaying-claim hazard in a different costume: a hardcoded number in prose is only true on the day it is written, and nothing fails when it goes stale. Pointing at the single source of truth is what stops it recurring. Precision check: the sweep touched only the suite-count claims — the three `93.75 MHz` PClock mentions and the `0x4E93_2C05` expected-value hex are verified unchanged. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
|
Warning Review limit reached
Next review available in: 2 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe accuracy ledger adds provenance for the corrected n64-systemtest total, expands R-14’s triangle edge slope resolution details, and aligns R-12, R-11, R-8, and R-7 status wording with the updated count rules. ChangesAccuracy ledger updates
Estimated code review effort: 1 (Trivial) | ~3 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 9 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (9 passed)
Comment |
All three Antigravity points, which materially improved this: - The 26-word parenthetical repeated nine times was genuine noise. Replaced by ONE authoritative note above the residuals table (carrying the detail: the 93->90 correction, the immutability rationale, and STATUS.md as the single source), plus a four-word uniform marker per entry. The short marker is kept rather than dropped so a reader who greps into a single row still sees that the number is as-at rather than current. - The italic syntax differed between entries (`**93** *` vs `93 *—`); every marker is now byte-identical in form. - R-11 ended up with back-to-back parenthetical fragments; the marker now follows the existing "(no systemtest drives the render path)" clause instead of splitting it. Still additive only: no historical claim is rewritten, and the three `93.75 MHz` PClock mentions and the `0x4E93_2C05` hex remain untouched. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
|
Adjudication of the Antigravity review (ledger stale counts, #168): Suggestion — nine copies of a 26-word disclaimer is significant noise; prefer a single note or a footnote: adopted (7e2b4d0). You're right, and the first version traded one readability problem for another. There is now one authoritative note above the residuals table carrying all the detail (the 93→90 correction, the immutability rationale, and Nitpick — inconsistent italic syntax between rows: adopted. Every marker is now byte-identical in form (verified: exactly one distinct string across all nine). Nitpick — R-11 ends up with back-to-back parenthetical fragments: adopted. The marker now follows the existing Still additive only — no historical claim is rewritten, and the precision check holds: the three Thanks — this one genuinely came out better for the review. |
|
@coderabbitai review |
✅ Action performedReview finished.
|
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@docs/accuracy-ledger.md`:
- Line 394: The R-14 entry uses an incomplete citation for the edge-coefficient
slope units. Replace the abbreviated “N64brew …/Commands §Edge Coefficients”
reference in the R-14 documentation with the complete primary-source page
title/path and exact section, preserving the surrounding explanation and other
citations.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: ASSERTIVE
Plan: Pro Plus
Run ID: 486d8603-19c9-4e89-8027-360b0e2ca529
📒 Files selected for processing (1)
docs/accuracy-ledger.md
…ot exist
CodeRabbit asked for the abbreviated `N64brew *…/Commands* §Edge Coefficients`
to be spelled out so it could be independently re-opened. Doing that found
something worse than an abbreviation: **there is no "Edge Coefficients" section**
in the page — the string does not appear anywhere in the wiki mirror.
The SUBSTANCE was right. The quoted phrase is verbatim in the page and the
fixed-point formats check out; they just live under §0x08 through 0x0F - Fill
Triangle, in the Base Command word tables:
dxhdy/dxmdy/dxldy -> "Integer part of change in x per change in y of line
connecting ..." (s13.16)
yh / ym / yl -> "s11.2 format" screen y coordinates
So the citation now names the section that exists, quotes the fields it rests
on, and records that the old section name was wrong — rather than quietly
swapping one label for another.
Every element of the new citation was verified against
`n64brew_wiki/markdown/Reality Display Processor/Commands.md` before committing
(heading, subheading, quoted phrase, both formats), and the absence of the old
section name was confirmed too.
This is the "cite the pages actually read" rule catching a citation that had
been carried for months: nothing fails when a section name is wrong, so it
survives review and then gets trusted.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Antigravity review (Gemini via Ultra)This documentation PR annotates historical Blocking issuesNone found. Suggestions
Nitpicks
Automated first-pass review by |
Motivation
Nine ledger entries state the n64-systemtest failing-assertion count as 93. That
was true when each was written, but Phase 5 dropped it to 90 — and the correction
lives ~1200 lines further down under "Measured n64-systemtest impact". A reader (or a
review bot) landing on R-8 / R-11 / R-16 / R-17 sees a stale number with no indication
it has moved. It has been flagged repeatedly across recent PRs.
What this does — and deliberately does not do
The ledger states its own policy at that correction note: the older entries are
"left as-is (historical, per the ledger's immutability discipline)". This PR
respects that and does not rewrite a single claim.
Instead each stale mention now carries a short parenthetical: that it is the count as
at that entry, that
docs/STATUS.mdis authoritative, and that the note belowcorrected it to 90. Additive only.
Why it is worth doing at all
This is the decaying-claim hazard in a different costume — the one this project
already has a lesson about. A hardcoded number in prose is only true on the day it is
written, nothing fails when it goes stale, and it then gets read as current. The
fix that stops it recurring is pointing at the single source of truth rather than
restating the value.
Precision
The sweep touched only the suite-count claims. Verified unchanged:
93.75 MHzPClock mentions (a clock rate, not a count)0x4E93_2C05expected-value hex in the FPU section0 unmarked stale suite-count claims remain; 9 marked.
Gates run locally
pre-commit run markdownlintandcargo test --workspace— green. Docs-only, nocode change.
🤖 Generated with Claude Code