docs(status): record the RSP-category Phase 2 criterion as met - #45
Conversation
Updates the single source of truth after #41–#44. The RSP vector unit was still listed as a stub ("COP2 retires inertly") and the suite-wide failure count was stale (250 -> 93). - Both n64-systemtest readiness tables now carry the RSP-category criterion as MET (0 RSP-prefixed failures, down from ~413 at Phase 1 close). - The RSP vector unit and the DPC command registers are marked implemented. - Adds an explicit Phase 2 status: one of two exit criteria met; v0.3.0 is not cut until the microcode/RDP-command-list criterion also holds. Docs-only. markdownlint green. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
|
Caution The consumer version of Gemini Code Assist on GitHub has been sunset. All code review activity has officially ceased. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
📝 WalkthroughSummary by CodeRabbit
WalkthroughUpdates ChangesStatus documentation
Estimated code review effort: 1 (Trivial) | ~2 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 9 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (9 passed)
Comment |
There was a problem hiding this comment.
Actionable comments posted: 3
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@docs/STATUS.md`:
- Around line 114-116: Update the three status rows in the documentation table
to include provenance for each hardware-behavior claim: cite authoritative
manual sections or accuracy-ledger entries and name regression tests covering
BREAK delay-slot behavior, reserved VU operations, and DPC START_VALID
double-latching/FREEZE semantics. Ensure undocumented behavior has both a cited
source and a test that fails if the behavior changes.
- Around line 13-28: Update the stale “not executable” status claims in
docs/STATUS.md, especially the statements around the n64-systemtest count and
runner output, to reflect the now-available real gate results shown in the
current status section. Remove or revise the conflicting Sprint 2 and “never
reports a real number” wording so the document consistently presents Phase 1 as
complete and treats docs/STATUS.md as the authoritative source.
- Around line 13-14: Add the RSP test started/completed count to the Phase 2 RSP
status entry at docs/STATUS.md lines 13-14, alongside the existing zero-failure
evidence. Apply the same count update to the corresponding RSP entry at
docs/STATUS.md lines 195-196, preserving the existing phase status and test
command.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: ASSERTIVE
Plan: Pro Plus
Run ID: d9813086-af98-4dc1-97b5-2813ebef7cd7
📒 Files selected for processing (1)
docs/STATUS.md
Adopts the three CodeRabbit comments on PR #45. - Removes the stale "n64-systemtest cannot report a count until Sprint 2 / the golden-log source returns an empty Vec / the second is never true" claims, which contradicted the MET rows. STATUS.md now states that basic.z64, n64-systemtest, and the golden log are all wired, executable gates reporting real numbers; only the visual goldens and accuracy battery remain staged. - Adds "across 917 tests started" to both RSP-category rows so the criterion is execution-backed, not failure-only. - Adds spec/provenance/regression pointers to the RSP-scalar, RSP-vector, and DPC feature-matrix rows (docs/rsp.md, docs/rdp.md, the N64brew Interface page, and the named test modules). Docs-only. markdownlint green. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@docs/STATUS.md`:
- Line 14: Update the n64-systemtest status entry to remove the ambiguous “was
~413 at Phase 1 close” parenthetical or explicitly qualify ~413 as the
suite-wide failure count. Preserve the existing RSP category result and use
docs/STATUS.md as the authoritative wording for historical counts.
- Around line 99-106: Update the opening sentence in the status section to say
“Three gates execute real results today,” distinguishing executable gates from
corpus entries while preserving the existing details about basic.z64,
n64-systemtest, and golden-log.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: ASSERTIVE
Plan: Pro Plus
Run ID: d529a565-d1e8-46c4-95be-9d9f3015085a
📒 Files selected for processing (1)
docs/STATUS.md
…ates Adopts CodeRabbit's two follow-up nits on PR #45. - The RSP-category row no longer implies 413 was an RSP-category count: 413 was the suite-wide total (of which RSP was the bulk), now 93. - "Three of these are executed by a gate" -> "Three gates execute real results today": the golden log is a gate, not a corpus entry, so the previous wording mixed the two terminologies. Docs-only. markdownlint green. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Motivation
docs/STATUS.mdis the single source of truth, and it fell out of date afterthe RSP work in #41–#44. It still listed the RSP vector unit as a stub ("COP2
retires inertly") and reported 250 suite-wide failures (now 93).
Changes (docs-only)
MET — 0 RSP-prefixed failures, down from ~413 at Phase 1 close.
command registers are marked implemented.
BREAKsemantics note updated (halts in a taken branch's delay slot).cut until the microcode / RDP-command-list criterion also holds.
Verification
The MET claims are the committed
#[ignore]d n64-systemtest runner, not aself-assessment. RSP-category zero was confirmed by dumping every remaining
failure and checking none are
RSP-prefixed.markdownlint green.
🤖 Generated with Claude Code