Fix of exception raise in case of auto_offset_reset is set to None in KafkaConsumer #860
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dpkp
approved these changes
Nov 18, 2016
Owner
dpkp
left a comment
dpkp
left a comment
There was a problem hiding this comment.
Thanks for the bugfix! I have a few comments about the new log statements. If you don't have time to get back to this, I can fix post-merge.
kafka/consumer/fetcher.py
Outdated
| self._offset_out_of_range_partitions[tp] = fetch_offset | ||
| log.info("Fetch offset %s is out of range, resetting offset", | ||
| fetch_offset) | ||
| log.info("Raising exception") |
Owner
There was a problem hiding this comment.
There are edge cases where we dont actually raise an exception -- if the partition gets marked unfetchable, or if a seek invalidates the fetch position.
kafka/consumer/fetcher.py
Outdated
| self._client.cluster.request_update() | ||
| elif error_type is Errors.OffsetOutOfRangeError: | ||
| fetch_offset = fetch_offsets[tp] | ||
| log.info("Fetch offset %s is out of range", fetch_offset) |
Owner
There was a problem hiding this comment.
This log statement should probably include the topic partition
kafka/consumer/fetcher.py
Outdated
| log.info("Fetch offset %s is out of range", fetch_offset) | ||
| if self._subscriptions.has_default_offset_reset_policy(): | ||
| self._subscriptions.need_offset_reset(tp) | ||
| log.info("Resetting offset") |
Owner
There was a problem hiding this comment.
Log statement should include the topic-partition
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without that patch exception wasn't raised, instead consumer keeps retrying fetching.