Skip to content

Fix of exception raise in case of auto_offset_reset is set to None in KafkaConsumer #860

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 27, 2016
Merged

Fix of exception raise in case of auto_offset_reset is set to None in KafkaConsumer #860

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
732e5a6
proper iteration over items and info messages
sibiryakov Oct 26, 2016
d5b5c3a
added tp-s and removed ambiguous message
sibiryakov Dec 16, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions kafka/consumer/fetcher.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -236,7 +236,7 @@ def _raise_if_offset_out_of_range(self):
current_out_of_range_partitions = {}

# filter only the fetchable partitions
for partition, offset in self._offset_out_of_range_partitions:
for partition, offset in six.iteritems(self._offset_out_of_range_partitions):
if not self._subscriptions.is_fetchable(partition):
log.debug("Ignoring fetched records for %s since it is no"
" longer fetchable", partition)
Expand Down Expand Up @@ -740,12 +740,12 @@ def _handle_fetch_response(self, request, send_time, response):
self._client.cluster.request_update()
elif error_type is Errors.OffsetOutOfRangeError:
fetch_offset = fetch_offsets[tp]
log.info("Fetch offset %s is out of range for topic-partition %s", fetch_offset, tp)
if self._subscriptions.has_default_offset_reset_policy():
self._subscriptions.need_offset_reset(tp)
log.info("Resetting offset for topic-partition %s", tp)
else:
self._offset_out_of_range_partitions[tp] = fetch_offset
log.info("Fetch offset %s is out of range, resetting offset",
fetch_offset)
elif error_type is Errors.TopicAuthorizationFailedError:
log.warn("Not authorized to read from topic %s.", tp.topic)
self._unauthorized_topics.add(tp.topic)
Expand Down