The standford_manipulator_modeling example is only modeled with DH convention. #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…atibility with the on going dqrobotics-matlab PR.
[standford_manipulator_modeling] Removed unnecessary commented code.
[stanford_manipulator_modeling] Commented the lines that use the class DQ_SerialManipulatorMDH since that class is not available yet.
6 tasks
bvadorno
approved these changes
Dec 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@dqrobotics/developers
Hi @bvadorno,
The example
standford_manipulator_modeling.mwas proposed to test the new classDQ_SerialManipulatorMDH()with respect to the classDQ_SerialManipulatorDHin a PR of dqrobotics-matlab (master branch) that was rejected. The example models the same robot using both conventions DH and MDH. However, the current PR that I'm preparing does not implement the classDQ_SerialManipulatorMDH(). So, I'm proposing to comment the lines that use DQ_SerialManipulatorMDH. Once the classDQ_SerialManipulatorMDH()be available, I'll update the example. Other option is to remove the example (standford_manipulator_modeling`) and update dqrobotics-matlab-test. What do you think?Best regards,
Juancho