Updating to 20 10

[juanjqo]

Status:

• Finished

Changes before we can update:

General

• Add the first version of the contributing file with the instructions for future contributors.

• The automatic documentation is not a priority in this pull request. Therefore, the original goal "Make Automatic documentation (C++ Doxygen documentation Problem in jacobian method #1)" will be addressed in future versions.

• Add DQ_SerialManipulatorMDH()

DQ_SerialManipulator

• Add get_{lower,upper}_{q,q_dot}_limit

• Add set_{lower,upper}_{q,q_dot}_limit

• Make it abstract.

DQ_SerialManipulatorDH

• Update it to support the changes in DQ_SerialManipulator

• Unify the {get,set}_{thetas, as, ds, alphas, types}

• Make a compatible pose_jacobian_derivative

• Deprecate the DQ_SerialManipulatorDH(MatrixXd, string) constructor.

DQ_Kinematics

• Update it to support the changes in DQ_SerialManipulator

[bvadorno]

Hi @juanjqo,

@mmmarinho and I concluded that this pull request is unfeasible to double-check and has several elements that are likely to be rejected.

Therefore,

1. restart the procedure with individual changes (several changes of the same type are allowed on the same pull request);
2. do not unnecessarily change any internal implementation that is working correctly without prior approval;
3. and include a clear and concise rationale behind each pull request.

Many thanks,
Bruno

[bvadorno]

Oh, by the way, @juanjqo, may you include the aforementioned information (i.e., items 1, 2, and 3) in the instructions for pull requests? I guess a good place would be the README.md files in each repository.

[juanjqo]

Oh, by the way, @juanjqo, may you include the aforementioned information (i.e., items 1, 2, and 3) in the instructions for pull requests? I guess a good place would be the README.md files in each repository.

@bvadorno Sure!

[juanjqo]

Hi @juanjqo,

@mmmarinho and I concluded that this pull request is unfeasible to double-check and has several elements that are likely to be rejected.

Therefore,

1. restart the procedure with individual changes (several changes of the same type are allowed on the same pull request);
2. do not unnecessarily change any internal implementation that is working correctly without prior approval;
3. and include a clear and concise rationale behind each pull request.

Many thanks, Bruno

@bvadorno I'll do that!