Merged
Conversation
When AMD Secure Memory Encryption is enabled, kernel memory is encrypted. When we map the ring buffer into userspace, we must mark it encrypted as well, otherwise corruption occurs both in the ring info (userspace writes unencrypted ->tail, then kernel reads the encrypted value and trips up on ASSERTs in record_event_consumer) and the buffer itself (userspace treats encrypted event data as plaintext leading to bogus lengths and eventually stack overflows by massive amounts).
anoop-sysd
approved these changes
Apr 4, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When AMD Secure Memory Encryption is enabled, kernel memory is
encrypted. When we map the ring buffer into userspace, we must mark it
encrypted as well, otherwise corruption occurs both in the ring info
(userspace writes unencrypted ->tail, then kernel reads the encrypted
value and trips up on ASSERTs in record_event_consumer) and the buffer
itself (userspace treats encrypted event data as plaintext leading to
bogus lengths and eventually stack overflows by massive amounts).