Merged
Conversation
mstemm
force-pushed
the
allow-k8s-filterchecks-analyzer
branch
from
9bcccd2 to
25918f0
Compare
Allow k8s filterchecks when compiling with the analyzer. This matches what we do for mesos--the filterchecks may not actually match events, as we don't directly connect the inspector to external mesos/k8s servers, but they will at least be defined. This also ensures that a falco rules file validated with open source falco will also be validated by the sysdig agent. As the analyzer does not have the necessary backing information for some previously ifdef'd out filterchecks, when HAS_ANALYZER is defined replace these with stubs that just return NULL/empty lists.
mstemm
force-pushed
the
allow-k8s-filterchecks-analyzer
branch
from
31d8c0a to
66d8fdc
Compare
mattpag
approved these changes
Jul 9, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allow k8s filterchecks when compiling with the analyzer. This matches
what we do for mesos--the filterchecks may not actually match events, as
we don't directly connect the inspector to external mesos/k8s servers,
but they will at least be defined.
This also ensures that a falco rules file validated with open source
falco will also be validated by the sysdig agent.