Skip to content

Fix for newer versions of LXC not being detected#1345

Merged
gnosek merged 1 commit intodraios:devfrom
JoeMattie:FIX-1344-lxc-not-detected
Mar 27, 2019
Merged

Fix for newer versions of LXC not being detected#1345
gnosek merged 1 commit intodraios:devfrom
JoeMattie:FIX-1344-lxc-not-detected

Conversation

@JoeMattie
Copy link
Contributor

/sys/fs/cgroup/cpuset/lxc

being split to

/sys/fs/cgroup/cpuset/lxc.monitor and /sys/fs/cgroup/cpuset/lxc.payload

now additionally looks for lxc.payload

sysdig-CLA-1.0-contributing-entity: Apolloversity Inc.
sysdig-CLA-1.0-signed-off-by: Joe Mattie joemattie@gmail.com

/sys/fs/cgroup/cpuset/lxc

being split to

/sys/fs/cgroup/cpuset/lxc.monitor and /sys/fs/cgroup/cpuset/lxc.payload

now additionally looks for lxc.payload

sysdig-CLA-1.0-contributing-entity: Apolloversity Inc.
sysdig-CLA-1.0-signed-off-by: Joe Mattie <joemattie@gmail.com>
@mfdii mfdii requested a review from gnosek March 26, 2019 18:31
@mfdii
Copy link
Contributor

mfdii commented Mar 26, 2019

Have you tested on older LXC (3.0.3) and a newer version (3.11)?

Thanks again for the PR.

@JoeMattie
Copy link
Contributor Author

Yes, confirmed working in LXC 3.0.3 installed from both apt and snap, and LXC 3.11 from snap

Copy link
Contributor

@gnosek gnosek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@gnosek gnosek merged commit 1cae3d4 into draios:dev Mar 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants