Conversation
added 23 commits
August 14, 2019 17:38
This reverts commit fec8b86.
…num (2/2)" This reverts commit da37652.
…num (1/2)" This reverts commit 2ac3111.
This reverts commit bc339ba.
This reverts commit 8adf0bb.
This reverts commit 31c9689.
This reverts commit dac75ef.
This reverts commit 4236e31.
This reverts commit 4b77b87.
This reverts commit 132ff12.
This reverts commit 188b9ee.
This reverts commit 5308360.
This reverts commit e0c9b99.
This reverts commit fa67879.
…vents" This reverts commit 27eff62.
This reverts commit cfa76c0.
This reverts commit 855664b.
This reverts commit 45261ef.
This reverts commit 8b82f50.
This reverts commit 5893893.
This reverts commit 1dc2fc1.
This reverts commit f65dfeb.
This reverts commit b95d398.
bryanseay
approved these changes
Aug 14, 2019
Contributor
bryanseay
left a comment
bryanseay
left a comment
There was a problem hiding this comment.
I did the same revert and we diff'd our changes and they were the same.
gnosek
approved these changes
Aug 15, 2019
nathan-b
pushed a commit
that referenced
this pull request
Aug 15, 2019
* Revert "Set container_id from lookup key" This reverts commit fec8b86. * Revert "Collapse m_metadata_complete and m_successful into a single enum (2/2)" This reverts commit da37652. * Revert "Collapse m_metadata_complete and m_successful into a single enum (1/2)" This reverts commit 2ac3111. * Revert "Track container lookup progress in a separate map" This reverts commit bc339ba. * Revert "Remove unused declarations" This reverts commit 8adf0bb. * Revert "`sinsp_container_manager` nits" This reverts commit 31c9689. * Revert "Make async CRI and async CRI resource lookup configurable" This reverts commit dac75ef. * Revert "Fully async CRI lookup" This reverts commit 4236e31. * Revert "Make CRI initialization a separate function" This reverts commit 4b77b87. * Revert "Use just one `container_info` struct" This reverts commit 132ff12. * Revert "Get CRI resource limits from cgroups" This reverts commit 188b9ee. * Revert "Support lookup of per-subsystem cgroup mount points" This reverts commit 5308360. * Revert "Allow lookup of specific cgroups of a thread by subsystem name" This reverts commit e0c9b99. * Revert "Configurable Docker socket" This reverts commit fa67879. * Revert "Don't roundtrip via JSON for internally generated container events" This reverts commit 27eff62. * Revert "Only do a container lookup once per engine" This reverts commit cfa76c0. * Revert "Convert docker to async engine infra" This reverts commit 855664b. * Revert "Make a helper method to get or create a container object" This reverts commit 45261ef. * Revert "Async container engine infrastructure, the common parts" This reverts commit 8b82f50. * Revert "Synchronize access to `container_manager::m_containers`" This reverts commit 5893893. * Revert "A simple mutex guard class, owning the locked data" This reverts commit 1dc2fc1. * Revert "Make container.h self-sufficient" This reverts commit f65dfeb. * Revert "Use `auto` for the value of `get_containers()`" This reverts commit b95d398.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.