Conversation
krishnan-ramkumar
approved these changes
Mar 24, 2020
Contributor
krishnan-ramkumar
left a comment
krishnan-ramkumar
left a comment
There was a problem hiding this comment.
LGTM -- Always work with iterators and never use [] for a lookup or modification is what I have learnt from experience.
m_value_map[key].m_available = false --> eeeek. So wrong on so many levels.
gnosek
approved these changes
Mar 25, 2020
Contributor
gnosek
left a comment
gnosek
left a comment
There was a problem hiding this comment.
Can't say I grok the patch enough to pinpoint the "here is the bug" line in the diff but if it helps...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There was a crash seen in
async_key_value_source::lookup_delayedwhere an invalid row was added to the table. After hardening the class to be explicit about when rows were added, the problem went away. The suspicion is that the lack of a copy constructor occasionally caused issues when inserting viaoperator[].