[#1979] Added support for xmlsitemap module for sitemap.xml generation.
#2264
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
Member
Author
|
Member
Author
|
Member
Author
|
AlexSkrypnyk
force-pushed
the
feature/1979-add-xmlsitemap
branch
from
f352a58 to
529de45
Compare
WalkthroughAdds the Drupal XML Sitemap module to the project: registers it with the installer, adds the Composer dependency, includes it in provisioning, supplies environment-specific settings, and adds Behat and PHPUnit tests verifying installation and configuration. Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Possibly related PRs
Suggested labels
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
🧪 Generate unit tests (beta)
Comment |
This comment has been minimized.
This comment has been minimized.
Member
Author
|
Member
Author
|
Member
Author
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2264 +/- ##
==========================================
- Coverage 77.05% 76.44% -0.61%
==========================================
Files 114 107 -7
Lines 5988 5830 -158
Branches 44 0 -44
==========================================
- Hits 4614 4457 -157
+ Misses 1374 1373 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
AlexSkrypnyk
force-pushed
the
feature/1979-add-xmlsitemap
branch
from
529de45 to
0c23b80
Compare
Member
Author
|
This comment has been minimized.
This comment has been minimized.
Member
Author
|
Member
Author
|
AlexSkrypnyk
force-pushed
the
feature/1979-add-xmlsitemap
branch
from
0c23b80 to
a1aedb2
Compare
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Fix all issues with AI agents
In `@web/sites/default/includes/modules/settings.xmlsitemap.php`:
- Around line 10-13: The conditional is accessing $settings['environment']
without a guard which can emit a PHP notice; update the if check to use a
null-coalescing or isset guard (e.g. ($settings['environment'] ?? NULL) or
isset($settings['environment']) ? $settings['environment'] : NULL) when
comparing to ENVIRONMENT_PROD, then keep the existing assignments to
$config['xmlsitemap.settings']['disable_cron_regeneration'] and
$config['xmlsitemap_engines.settings']['submit'] unchanged so the block only
runs when the environment value exists and is not ENVIRONMENT_PROD.
Comment on lines
+10
to
+13
| // Disable submitting sitemap to search engines in non-production environments. | ||
| if ($settings['environment'] !== ENVIRONMENT_PROD) { | ||
| $config['xmlsitemap.settings']['disable_cron_regeneration'] = TRUE; | ||
| $config['xmlsitemap_engines.settings']['submit'] = FALSE; |
There was a problem hiding this comment.
Guard against missing environment setting to avoid notices.
If $settings['environment'] isn’t defined when this include runs, PHP emits a notice. Use a null-coalescing guard.
Proposed fix
-if ($settings['environment'] !== ENVIRONMENT_PROD) {
+if (($settings['environment'] ?? null) !== ENVIRONMENT_PROD) {
$config['xmlsitemap.settings']['disable_cron_regeneration'] = TRUE;
$config['xmlsitemap_engines.settings']['submit'] = FALSE;
}🤖 Prompt for AI Agents
In `@web/sites/default/includes/modules/settings.xmlsitemap.php` around lines 10 -
13, The conditional is accessing $settings['environment'] without a guard which
can emit a PHP notice; update the if check to use a null-coalescing or isset
guard (e.g. ($settings['environment'] ?? NULL) or
isset($settings['environment']) ? $settings['environment'] : NULL) when
comparing to ENVIRONMENT_PROD, then keep the existing assignments to
$config['xmlsitemap.settings']['disable_cron_regeneration'] and
$config['xmlsitemap_engines.settings']['submit'] unchanged so the block only
runs when the environment value exists and is not ENVIRONMENT_PROD.
|
Member
Author
|
Member
Author
|
Member
Author
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1979
Summary by CodeRabbit
New Features
Chores
Tests