Added installer selection for Gitleaks secret scanning.#2781
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository UI Review profile: ASSERTIVE Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
WalkthroughThis PR adds a new ChangesGitleaks Installer Handler
Estimated code review effort: 2 (Simple) | ~10 minutes Possibly related PRs
Suggested labels: Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In @.vortex/installer/tests/Functional/Handlers/GitleaksHandlerProcessTest.php:
- Around line 13-20: The data provider in dataProviderHandlerProcess currently
includes both enabled and disabled Gitleaks cases, but Gitleaks::default()
already covers the enabled baseline. Remove the gitleaks_enabled dataset and
keep only gitleaks_disabled so the test focuses on the only path that produces a
snapshot diff, while leaving the Gitleaks::id() prompt setup intact.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository UI
Review profile: ASSERTIVE
Plan: Pro Plus
Run ID: 54de9dd8-f651-4926-81e9-79d6049d57bd
⛔ Files ignored due to path filters (4)
.vortex/docs/static/img/installer.pngis excluded by!**/*.png.vortex/docs/static/img/installer.svgis excluded by!**/*.svg.vortex/installer/tests/Fixtures/handler_process/gitleaks_disabled/-.gitleaks.tomlis excluded by!.vortex/installer/tests/Fixtures/**.vortex/installer/tests/Fixtures/handler_process/gitleaks_disabled/.github/workflows/build-test-deploy.ymlis excluded by!.vortex/installer/tests/Fixtures/**
📒 Files selected for processing (7)
.circleci/config.yml.github/workflows/build-test-deploy.yml.vortex/docs/static/img/installer.json.vortex/installer/src/Prompts/Handlers/Gitleaks.php.vortex/installer/src/Prompts/PromptManager.php.vortex/installer/tests/Functional/Handlers/GitleaksHandlerProcessTest.php.vortex/installer/tests/Unit/Handlers/AbstractHandlerTypeTest.php
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
2 similar comments
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2781 +/- ##
==========================================
- Coverage 86.69% 86.23% -0.47%
==========================================
Files 96 90 -6
Lines 4727 4583 -144
Branches 47 3 -44
==========================================
- Hits 4098 3952 -146
- Misses 629 631 +2 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
1 similar comment
This comment has been minimized.
This comment has been minimized.
|
📖 Documentation preview for this pull request has been deployed to Netlify: https://6a4f3406be3dda47868f8259--vortex-docs.netlify.app This preview is rebuilt on every commit and is not the production documentation site. |
|
Code coverage (threshold: 90%) Per-class coverage |
This comment has been minimized.
This comment has been minimized.
2 similar comments
This comment has been minimized.
This comment has been minimized.
|
Code coverage (threshold: 90%) Per-class coverage |
Summary
Makes the Gitleaks secret-scanning CI step (added to Vortex CI in the 1.40 release) selectable in the installer, instead of being shipped unconditionally to every generated project. The new prompt defaults to enabled, so the out-of-the-box behavior for existing installer flows is unchanged.
Changes
.vortex/installer/src/Prompts/Handlers/Gitleaks.php: a Confirm prompt in the "Continuous Integration" section, defaulting to enabled. On opt-out, itsprocess()removes the Gitleaks CI step from both CI providers (via the newCI_GITLEAKSfence token) and deletes the.gitleaks.tomlconfig file..github/workflows/build-test-deploy.ymland.circleci/config.ymlis now wrapped in#;< CI_GITLEAKS/#;> CI_GITLEAKSconditional fences, the established token pattern already used byTOOL_PHPCS,MODULE_SDC_DEVEL, and others. When enabled (default) the markers are stripped and the step is retained byte-identical to before; when disabled the fenced block is removed entirely..vortex/installer/src/Prompts/PromptManager.php: registered the handler (import, prompt added to the CI section after Visual regression, reverse-order processor entry, response-summary line) and bumpedTOTAL_RESPONSESfrom 35 to 36..vortex/installer/tests/Functional/Handlers/GitleaksHandlerProcessTest.phpcovering enabled and disabled scenarios; added agitleaksentry inAbstractHandlerTypeTest; and registered the new prompt in the sharedAbstractHandlerDiscoveryTestCaseexpectation helpers (getExpectedDefaults,getExpectedInstalled,defaultTuiAnswers), which the ~30 handler-discovery tests assert against as a complete responses array.gitleaks_disabledsnapshot fixture under.vortex/installer/tests/Fixtures/handler_process/was regenerated to match the new handler output, and the installer demo video (installer.json/.svg/.png) was regenerated to record the new 36-prompt flow.Screenshots
N/A - this is a non-visual change (installer PHP logic, CI YAML fencing, and regenerated test fixtures/demo video).
Before / After
Installer prompt flow - "Continuous Integration" section:
CI YAML step - unconditional versus fenced/conditional:
Summary by CodeRabbit