[#2782] Added installer selection for Twig CS Fixer in the Tools multiselect.#2783
Merged
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository UI Review profile: ASSERTIVE Plan: Pro Plus Run ID: ⛔ Files ignored due to path filters (28)
📒 Files selected for processing (7)
WalkthroughAdds a new ChangesTwig CS Fixer Tool Selection
Estimated code review effort: 2 (Simple) | ~10 minutes Suggested labels: Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Warning Tools execution failed with the following error: Failed to run tools: 13 INTERNAL: Received RST_STREAM with code 2 (Internal server error) Comment |
|
Code coverage (threshold: 90%) Per-class coverage |
This comment has been minimized.
This comment has been minimized.
2 similar comments
This comment has been minimized.
This comment has been minimized.
Member
Author
|
Code coverage (threshold: 90%) Per-class coverage |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2783 +/- ##
==========================================
- Coverage 86.67% 86.27% -0.40%
==========================================
Files 97 90 -7
Lines 4742 4598 -144
Branches 47 3 -44
==========================================
- Hits 4110 3967 -143
+ Misses 632 631 -1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
📖 Documentation preview for this pull request has been deployed to Netlify: https://6a4f676cd2b1f330c6130aad--vortex-docs.netlify.app This preview is rebuilt on every commit and is not the production documentation site. |
AlexSkrypnyk
added
the
Needs review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #2782
Summary
Twig CS Fixer was the last linter shipped unconditionally by Vortex: its siblings - PHPCS, PHPStan, Rector, ESLint and Stylelint - are all selectable through the
Toolsmultiselect handler, butvincentlanglet/twig-cs-fixerand its CI step had no installer opt-out.This adds a
TWIG_CS_FIXERentry toTools::getToolDefinitions()so deselecting it removes the composer dependency, the.twig-cs-fixer.phpconfig, theahoylint commands, and the CI step in both providers - the same pattern already used for the other linters, and the direct follow-up to the Gitleaks installer selection added in #2781.Changes
TWIG_CS_FIXERentry toTools::getToolDefinitions()in.vortex/installer/src/Prompts/Handlers/Tools.php(presentdetection via avincentlanglet/twig-cs-fixercomposer reference or an existing.twig-cs-fixer.php; removes the composer dependency, the config file, and theahoy cli vendor/bin/twig-cs-fixer lint/lint --fixcommands), and added it to the default and discoverable tool lists.#;< TOOL_TWIG_CS_FIXER/#;> TOOL_TWIG_CS_FIXERfences in both.github/workflows/build-test-deploy.ymland.circleci/config.yml, matching the fencing already used forTOOL_PHPCSand the other conditional tools.tools - discovery - twig_cs_fixerandtools - discovery - twig_cs_fixer, altcases toToolsHandlerDiscoveryTest, added thetwig-cs-fixer/vincentlanglet/twig-cs-fixerpair to the "all tools installed" assertion inToolsHandlerProcessTest, and addedtools_no_twig/tools_no_twig_circleciscenarios exercising both CI providers; updated the sharedAbstractHandlerDiscoveryTestCase::getExpectedDefaults()/getExpectedInstalled()baseline to includeTools::TWIG_CS_FIXER..vortex/installer/tests/Fixtures/handler_process/snapshots - newtools_no_twigandtools_no_twig_circleciscenario fixtures, and an updatedtools_noneto reflect the additional tool.installer.json/.svg/.png) so the recorded Tools list includes the new option.Screenshots
N/A - template repository with no running site to capture; the installer demo asset is part of the diff (
.vortex/docs/static/img/installer.png).Before / After
Installer "Tools" multiselect - selectable tools before vs after:
CI YAML step - unconditional versus fenced/conditional:
Summary by CodeRabbit
New Features
Bug Fixes
Tests