General image and content updates - #372
Conversation
📝 WalkthroughWalkthroughSix help articles are updated to replace external Dub assets CDN image URLs with locally hosted ChangesHelp Documentation Asset Migration
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~5 minutes Possibly related PRs
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 inconclusive)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Warning There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure. 🔧 ESLint
ESLint skipped: no ESLint configuration detected in root package.json. To enable, add Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (2)
help/article/how-to-export-analytics.mdx (1)
13-13: 🛠️ Refactor suggestion | 🟠 Major | ⚡ Quick winComplete the asset migration for remaining external CDN images.
Two images still reference external Dub CDN URLs (
https://assets.dub.co/help/...) while the other images in this file were successfully migrated to local paths. This is inconsistent with the PR objective to replace external CDN URLs with locally hosted/images/...paths.Consider migrating:
- Line 13:
import-zip-bi.png- Line 57:
download-file.png♻️ Suggested migration
<Frame> <img - src="https://assets.dub.co/help/import-zip-bi.png" + src="/images/dub-links/import-zip-bi.png" alt="CSV files are agnostic and can be opened in a variety of tools" /> </Frame><Frame> <img - src="https://assets.dub.co/help/download-file.png" + src="/images/dub-links/download-file.png" alt="Find the CSV files in the downloaded zip file" /> </Frame>Also applies to: 57-57
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@help/article/how-to-export-analytics.mdx` at line 13, Two external CDN images remain; change the img src attributes referencing "https://assets.dub.co/help/import-zip-bi.png" and "https://assets.dub.co/help/download-file.png" in help/article/how-to-export-analytics.mdx to local paths (e.g. "/images/import-zip-bi.png" and "/images/download-file.png"), ensure those image files are present in the repository's images folder, and keep the existing alt/title text unchanged.help/article/filter-analytics-by-utms.mdx (1)
14-18:⚠️ Potential issue | 🟡 Minor | ⚡ Quick winMigrate this image to local hosting for consistency.
This image still uses the external CDN URL (
assets.dub.co) while all other images in this file and across the PR have been migrated to local/images/dub-links/...paths. This creates an inconsistency with the PR objective.🖼️ Proposed fix to align with local asset migration
- src="https://assets.dub.co/cms/utm-analytics.jpg" + src="/images/dub-links/utm-analytics.png"Note: Ensure the local image file exists at the specified path.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@help/article/filter-analytics-by-utms.mdx` around lines 14 - 18, The img tag in help/article/filter-analytics-by-utms.mdx is still pointing to the external CDN ("https://assets.dub.co/cms/utm-analytics.jpg"); replace that src value with the local path used across the PR (e.g. "/images/dub-links/utm-analytics.jpg") so the file is hosted locally and consistent with other images, and verify the local image file exists at that path before committing.
🧹 Nitpick comments (2)
help/article/share-analytics.mdx (1)
34-34: ⚡ Quick winConsider completing the image migration for consistency.
This file now has a mix of local image paths (line 34) and external CDN URLs (lines 25, 43, 52, 67, 76, 85, 102, 111, 122, and 131). With 10 images still referencing the external CDN, this creates significant inconsistency within the article. For maintainability and to establish a unified asset hosting pattern, consider migrating all images to local paths.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@help/article/share-analytics.mdx` at line 34, This article mixes local images (e.g., src="/images/dub-links/analytics-share-button.png") with many external CDN URLs; please migrate the remaining CDN-hosted images to the local assets folder (use the same /images/dub-links/ pattern), add the image files into that directory, and update their src attributes in share-analytics.mdx to point to the new local paths; after updating, verify each image reference (the CDN URLs on lines 25, 43, 52, 67, 76, 85, 102, 111, 122, 131) is replaced, confirm alt text remains correct, and run the site build to ensure no broken links.help/article/how-to-set-primary-domain.mdx (1)
13-13: ⚡ Quick winConsider completing the image migration for consistency.
This file now has a mix of local image paths (line 13) and external CDN URLs (lines 48 and 57). For consistency and to avoid maintaining two different asset hosting patterns in the same article, consider migrating all images to local paths.
♻️ Proposed updates for remaining external image URLs
<Frame> <img - src="https://assets.dub.co/help/domain-popover-menu-primary.png" + src="/images/workspace/domain-popover-menu-primary.png" alt="More options popover" /> </Frame><Frame> <img - src="https://assets.dub.co/help/primary-domain-modal.png" + src="/images/workspace/primary-domain-modal.png" alt="Set as primary domain modal" /> </Frame>Also applies to: 48-48, 57-57
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@help/article/how-to-set-primary-domain.mdx` at line 13, The article mixes local and CDN-hosted images; standardize by migrating the external CDN images to the local images directory and updating their mdx image references to the same local pattern used by src="/images/dub-links/create-link-default-domain.png"; copy the CDN image files into the repository (e.g., /images/dub-links/), name them consistently, replace the external URLs in the MDX with the new local src paths, and verify the images render and paths use the same "/images/dub-links/..." convention throughout the document.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Outside diff comments:
In `@help/article/filter-analytics-by-utms.mdx`:
- Around line 14-18: The img tag in help/article/filter-analytics-by-utms.mdx is
still pointing to the external CDN
("https://assets.dub.co/cms/utm-analytics.jpg"); replace that src value with the
local path used across the PR (e.g. "/images/dub-links/utm-analytics.jpg") so
the file is hosted locally and consistent with other images, and verify the
local image file exists at that path before committing.
In `@help/article/how-to-export-analytics.mdx`:
- Line 13: Two external CDN images remain; change the img src attributes
referencing "https://assets.dub.co/help/import-zip-bi.png" and
"https://assets.dub.co/help/download-file.png" in
help/article/how-to-export-analytics.mdx to local paths (e.g.
"/images/import-zip-bi.png" and "/images/download-file.png"), ensure those image
files are present in the repository's images folder, and keep the existing
alt/title text unchanged.
---
Nitpick comments:
In `@help/article/how-to-set-primary-domain.mdx`:
- Line 13: The article mixes local and CDN-hosted images; standardize by
migrating the external CDN images to the local images directory and updating
their mdx image references to the same local pattern used by
src="/images/dub-links/create-link-default-domain.png"; copy the CDN image files
into the repository (e.g., /images/dub-links/), name them consistently, replace
the external URLs in the MDX with the new local src paths, and verify the images
render and paths use the same "/images/dub-links/..." convention throughout the
document.
In `@help/article/share-analytics.mdx`:
- Line 34: This article mixes local images (e.g.,
src="/images/dub-links/analytics-share-button.png") with many external CDN URLs;
please migrate the remaining CDN-hosted images to the local assets folder (use
the same /images/dub-links/ pattern), add the image files into that directory,
and update their src attributes in share-analytics.mdx to point to the new local
paths; after updating, verify each image reference (the CDN URLs on lines 25,
43, 52, 67, 76, 85, 102, 111, 122, 131) is replaced, confirm alt text remains
correct, and run the site build to ensure no broken links.
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: cded3fe8-c78a-40e2-a30d-df2b2c7e48f9
⛔ Files ignored due to path filters (12)
images/dub-links/analytics-share-button.pngis excluded by!**/*.pngimages/dub-links/create-link-default-domain.pngis excluded by!**/*.pngimages/dub-links/export-analytics-dropdown.pngis excluded by!**/*.pngimages/dub-links/export-analytics-nav.pngis excluded by!**/*.pngimages/dub-links/filter-tag-analytics-multiple.pngis excluded by!**/*.pngimages/dub-links/filter-tag-analytics.pngis excluded by!**/*.pngimages/dub-links/filter-tag-dropdown.pngis excluded by!**/*.pngimages/dub-links/filter-tag.pngis excluded by!**/*.pngimages/dub-links/filter-utmsource-analytics.pngis excluded by!**/*.pngimages/dub-links/filter-utmsource-dropdown.pngis excluded by!**/*.pngimages/dub-links/filter-utmsource.pngis excluded by!**/*.pngimages/workspace/archived-domains.pngis excluded by!**/*.png
📒 Files selected for processing (6)
help/article/archiving-domains.mdxhelp/article/filter-analytics-by-tags.mdxhelp/article/filter-analytics-by-utms.mdxhelp/article/how-to-export-analytics.mdxhelp/article/how-to-set-primary-domain.mdxhelp/article/share-analytics.mdx
|
Preview deployment for your docs. Learn more about Mintlify Previews.
💡 Tip: Enable Workflows to automatically generate PRs for you. |
1 participant
Summary by CodeRabbit