Skip to content

Jul3 lander images - #405

Merged
marcusljf merged 2 commits into
mainfrom
jul3-lander-images
Jul 3, 2026
Merged

Jul3 lander images#405
marcusljf merged 2 commits into
mainfrom
jul3-lander-images

Conversation

@marcusljf

@marcusljf marcusljf commented Jul 3, 2026

Copy link
Copy Markdown
Collaborator

Adding more lander image content

Summary by CodeRabbit

  • Documentation
    • Updated the landing page help article to clarify that images default to the page’s content width.
    • Replaced the existing image preview example with a new framed visual and updated descriptive text.

@mintlify

mintlify Bot commented Jul 3, 2026

Copy link
Copy Markdown
Contributor

Preview deployment for your docs. Learn more about Mintlify Previews.

Project Status Preview Updated (UTC)
Dub 🟢 Ready View Preview Jul 3, 2026, 8:57 PM

💡 Tip: Enable Workflows to automatically generate PRs for you.

@coderabbitai

coderabbitai Bot commented Jul 3, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

📝 Walkthrough

Walkthrough

Documentation update to help/article/program-landing-page.mdx adding guidance text about default image width behavior in the "Image" content type section, and replacing the prior empty preview area with a new framed guide image and alt text.

Changes

Documentation Update

Layer / File(s) Summary
Image section guidance and asset
help/article/program-landing-page.mdx
Added instructional copy clarifying default image width behavior and inserted a new framed guide image (lander-image-guide.jpg) with updated alt text, removing the prior empty insertion area.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Possibly related PRs

  • dubinc/docs#355: Both PRs update image preview/frame guidance assets in help articles.
  • dubinc/docs#372: Both PRs update embedded help-article images and related alt text.
  • dubinc/docs#397: Both PRs adjust guidance and visuals for image insertion/alt text within help/article pages.
🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name Status Explanation Resolution
Title check ❓ Inconclusive The title is related to the image updates, but "Jul3" is date-like and the phrasing is too vague to clearly describe the change. Rename it to something specific, like "Add landing page image guidance" or "Update lander image documentation".
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch jul3-lander-images

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹 Nitpick comments (1)
help/article/program-landing-page.mdx (1)

123-124: 📐 Maintainability & Code Quality | 🔵 Trivial | 💤 Low value

Extra blank line before next section.

Two consecutive blank lines here vs. a single blank line elsewhere between a closing </Frame> and the next heading (e.g., lines 79-81, 91-93).

🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@help/article/program-landing-page.mdx` around lines 123 - 124, There is an
extra blank line before the next section after the closing Frame block. Update
the markdown in the article content so the spacing matches the rest of the file
by using a single blank line between </Frame> and the following heading,
consistent with the other Frame sections.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Nitpick comments:
In `@help/article/program-landing-page.mdx`:
- Around line 123-124: There is an extra blank line before the next section
after the closing Frame block. Update the markdown in the article content so the
spacing matches the rest of the file by using a single blank line between
</Frame> and the following heading, consistent with the other Frame sections.

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 5965be26-480d-450c-87d1-17de3d26d271

📥 Commits

Reviewing files that changed from the base of the PR and between 14382cb and 074619d.

⛔ Files ignored due to path filters (1)
  • images/dub-partners/lander-image-guide.jpg is excluded by !**/*.jpg
📒 Files selected for processing (1)
  • help/article/program-landing-page.mdx

@marcusljf
marcusljf merged commit 2dbfcb7 into main Jul 3, 2026
4 checks passed
@marcusljf
marcusljf deleted the jul3-lander-images branch July 3, 2026 20:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant