Onboarding Brand Design Update: Add in-context SERP dialog

[mikescamell]

Task/Issue URL: https://app.asana.com/1/137249556945/project/1207908166761516/task/1212699268790179?focus=true

Description

Migrates the SERP contextual onboarding dialog ("DuckDuckGo Search!") to the new brand-design layout, gated behind the onboardingBrandDesignUpdate feature flag. Lays the foundation (base class, include layouts, dismiss button styling, banner-animation pipeline, rotation handling) that the remaining contextual CTAs will plug into in follow-up PRs.

With the flag on:

• SERP CTA renders in the new card chrome with title and body as distinct blocks (legacy was a single inline-bolded sentence).
• SERP background banner slides up from behind the card on appear and slides out on dismiss / content swap.
• New circular bordered dismiss button plus a two-layer drop shadow at the bottom edge so the dialog reads as a layer above the browser content.

Out of scope (still legacy / stub-only with the flag on): fire-button, no-trackers, main-network, trackers-blocked, site-suggestions, end. Dax*BrandDesignUpdateContextualCta classes exist as scaffolding for follow-ups.

Why all the rotation-handling code

BrowserActivity declares android:configChanges="keyboardHidden|orientation|screenSize|smallestScreenSize|screenLayout|navigation|keyboard" in AndroidManifest.xml, so Android does not recreate the activity on orientation changes — onConfigurationChanged fires and the existing view tree stays in place. The system never auto-swaps the layout-land variant in for us, so we have to do it manually. That's why this PR introduces:

• Command.ReinflateBrandDesignContextualDialog emitted from the VM on orientation change (only when the brand-design flag is enabled).
• BrowserTabFragmentRenderer.reinflateContextualBrandDesignDialog() which inflates the new orientation's layout, transplants its children into the existing root, and re-shows the CTA via a new instantShow snap path so it lands fully populated (no replay of the typing animation).
• A landscape variant of include_onboarding_in_context_dax_dialog_brand_design_update.xml plus orientation-keyed bools.xml for the options-content height cap.
• Coordination with the animation pipeline: running animators are cancelled before re-inflation, a visibility guard prevents resurrecting a dismissed CTA, and the onCtaShown pixel is gated so it doesn't double-fire on rotation re-inflate.

Other notes

• Dev-settings fix so the bulk "Onboarding Completed" toggle clears DAX_DIALOG_NETWORK / DAX_DIALOG_OTHER flags — without it, iterative testing of the contextual stack silently fails to re-show the in-context site-suggestions dialog after reset.
• cancelRunningAnimations() added to both BrandDesignUpdateBubbleCta (pre-existing, same gap on develop) and the new contextual base class — running fade-in/fade-out AnimatorSets and the container's ViewPropertyAnimator now get cancelled on dismiss so their listeners can't fire on a .gone() view.
• Telemetry parity: pixel names, ctaPixelParam, and ctaId match the legacy DaxSerpCta exactly — no new pixels, no renamed params.

Steps to test this PR

Designs

Please run all testing steps for in-context dialog changes from the contextual-end branch/PR to ease the testing burden

To see these changes patch (Linear onboarding flag included just for continuity)

Index: app/src/main/java/com/duckduckgo/app/onboardingbranddesignupdate/OnboardingBrandDesignUpdateToggles.kt
IDEA additional info:
Subsystem: com.intellij.openapi.diff.impl.patch.CharsetEP
<+>UTF-8
===================================================================
diff --git a/app/src/main/java/com/duckduckgo/app/onboardingbranddesignupdate/OnboardingBrandDesignUpdateToggles.kt b/app/src/main/java/com/duckduckgo/app/onboardingbranddesignupdate/OnboardingBrandDesignUpdateToggles.kt
--- a/app/src/main/java/com/duckduckgo/app/onboardingbranddesignupdate/OnboardingBrandDesignUpdateToggles.kt	(revision 6fd565c8894daba16281ae9bcf3452d038ae8d6d)
+++ b/app/src/main/java/com/duckduckgo/app/onboardingbranddesignupdate/OnboardingBrandDesignUpdateToggles.kt	(date 1777967047929)
@@ -34,13 +34,13 @@
      * Main toggle for the onboarding brand design update feature.
      * Default value: false (disabled).
      */
-    @Toggle.DefaultValue(DefaultFeatureValue.FALSE)
+    @Toggle.DefaultValue(DefaultFeatureValue.TRUE)
     fun self(): Toggle
 
     /**
      * Toggle for the brand design update variant.
      * Default value: false (disabled).
      */
-    @Toggle.DefaultValue(DefaultFeatureValue.FALSE)
+    @Toggle.DefaultValue(DefaultFeatureValue.TRUE)
     fun brandDesignUpdate(): Toggle
 }
Index: app/src/main/java/com/duckduckgo/app/onboarding/ui/OnboardingViewModel.kt
IDEA additional info:
Subsystem: com.intellij.openapi.diff.impl.patch.CharsetEP
<+>UTF-8
===================================================================
diff --git a/app/src/main/java/com/duckduckgo/app/onboarding/ui/OnboardingViewModel.kt b/app/src/main/java/com/duckduckgo/app/onboarding/ui/OnboardingViewModel.kt
--- a/app/src/main/java/com/duckduckgo/app/onboarding/ui/OnboardingViewModel.kt	(revision 6fd565c8894daba16281ae9bcf3452d038ae8d6d)
+++ b/app/src/main/java/com/duckduckgo/app/onboarding/ui/OnboardingViewModel.kt	(date 1777657893440)
@@ -45,7 +45,7 @@
     val viewState = _viewState.asStateFlow()
 
     fun initializePages() {
-        pageLayoutManager.buildPageBlueprints()
+        pageLayoutManager.buildBrandDesignUpdatePageBlueprints()
     }
 
     fun pageCount(): Int {
@@ -69,8 +69,8 @@
         }
     }
 
-    fun initializeOnboardingSkipper() {
-        if (!appBuildConfig.canSkipOnboarding) return
+    fun initializeOnboardingSkipper() { 
+        return
 
         // delay showing skip button until privacy config downloaded
         viewModelScope.launch {

UI changes

See here

---

Note

Medium Risk
Touches onboarding CTA rendering/animation flow and adds orientation-specific reinflation logic, which could regress CTA visibility/dismissal or double-fire pixels if edge cases slip through. Changes are mostly UI/flow-gated behind the brand-design toggle but affect core BrowserTabFragment/BrowserTabViewModel CTA handling.

Overview
Adds a new brand-design in-context onboarding dialog pipeline by introducing OnboardingDaxDialogCta.BrandDesignContextualDaxDialogCta (animations, tap-to-skip, background banner, and safe animation cancellation) plus new layouts/drawables for the contextual card (including a new shadow treatment and shared dismiss button styling).

Migrates the SERP contextual CTA to this new layout when the onboardingBrandDesignUpdate toggle is enabled via DaxSerpBrandDesignUpdateContextualCta, and adds stub Dax*BrandDesignUpdateContextualCta classes as scaffolding for future CTAs.

Improves config-change handling by detecting orientation changes, emitting a new Command.ReinflateBrandDesignContextualDialog, and reinflating the brand-design contextual layout instantly to pick up layout-land resources without replaying animations; updates hide/dismiss paths to cancel running animations and handle brand-design vs legacy containers correctly.

Updates theming/strings/resources to support the new UI (new onboarding shadow attrs, SERP title/description string split across locales, contextual overlap/capped height dims/bools) and expands onboarding dev settings to include additional dialog CTAs; adds unit tests covering reinflation command emission and the new banner/snap state helpers.

^{Reviewed by Cursor Bugbot for commit 113d5b1. Bugbot is set up for automated code reviews on this repo. Configure here.}

[mikescamell]

• Onboarding Brand Design Update: Dismiss intro bubble on submit #8526
• Onboarding Brand Design Update: Update welcome screen copy #8515
• Onboarding Brand Design Update: Add Default Browser page #8514
• Onboarding Brand Design Update: Add in-context End dialog #8484
• Onboarding Brand Design Update: Add in-context Fire Button dialog + Inferno fire animation #8482
• Onboarding Brand Design Update: Add in-context No Trackers dialog #8481
• Onboarding Brand Design Update: Add in-context Main Network dialog #8480
• Onboarding Brand Design Update: Add in-context Trackers Blocked dialog #8479
• Onboarding Brand Design Update: Add in-context Site Suggestions dialog #8483
• Onboarding Brand Design Update: Add in-context SERP dialog #8439 👈 (View in Graphite)
• develop

This stack of pull requests is managed by Graphite. Learn more about stacking.

[cursor]

Cursor Bugbot has reviewed your changes and found 1 potential issue.

^{❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.}

^{Reviewed by Cursor Bugbot for commit 113d5b1. Configure here.}

[cursor]

Hardcoded 2dp margins instead of @dimen/keyline_0

Low Severity

Three android:layout_marginTop="2dp" attributes use hardcoded dp values instead of @dimen/keyline_0 (which is 2dp). The codebase requires @dimen/keyline_* references for margin and padding attributes to maintain consistent spacing. 2dp is not a standard multiple of 4dp, so it doesn't fall under the exemption for values that likely correspond to an existing keyline — it exactly IS keyline_0 and the reference form is expected.

---

_{Please tell me if this was useful or not with a 👍 or 👎.}

Additional Locations (2)

• app/src/main/res/layout/include_brand_design_contextual_dialog_options.xml#L50-L51
• app/src/main/res/layout/include_brand_design_contextual_dialog_options.xml#L59-L60

 

^{Triggered by learned rule: Use @dimen/keyline_* references for margin and padding in layout XML}

^{Reviewed by Cursor Bugbot for commit 113d5b1. Configure here.}