Onboarding Brand Design Update: Add in-context No Trackers dialog#8481
Draft
Conversation
Contributor
Author
This was referenced May 7, 2026
Draft
fd3becf to
8856449
Compare
cc16580 to
071b244
Compare
071b244 to
64da96e
Compare
8856449 to
2be56dc
Compare
64da96e to
ec42745
Compare
2be56dc to
6ddfea5
Compare
ec42745 to
6e285f7
Compare
6ddfea5 to
4216fc8
Compare
6e285f7 to
e306f79
Compare
4216fc8 to
fba4c97
Compare
13 tasks
e306f79 to
d0d5650
Compare
fba4c97 to
87c0686
Compare
This was referenced May 11, 2026
d0d5650 to
3c09cc1
Compare
080f06d to
569bb3c
Compare
3c09cc1 to
538855a
Compare
Reuses bg_onboarding_trackers_blocked, the shared post-page-load banner.
569bb3c to
d6c77f4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Task/Issue URL: https://app.asana.com/1/137249556945/project/1207908166761516/task/1214598065379693?focus=true
Description
Migrates the No Trackers contextual onboarding dialog to the new brand-design layout introduced in #8439, gated behind the
onboardingBrandDesignUpdatefeature flag.With the flag on:
Out of scope (still legacy / stub-only with the flag on, queued in follow-up PRs in this stack): fire-button, end. Their
Dax*BrandDesignUpdateContextualCtaclasses remain as scaffolding.Steps to test this PR
Designs
Please run all testing steps for in-context dialog changes from the contextual-end branch/PR to ease the testing burden.
To see these changes patch (Linear onboarding flag included just for continuity)
UI changes
Screenshots
Note
Low Risk
Low risk: gated behind the onboarding brand-design feature toggle and limited to onboarding CTA UI rendering/selection plus unit tests; main risk is incorrect CTA selection or layout binding when the flag is enabled.
Overview
Updates in-context onboarding to use the new brand-design layout for the “No Trackers” CTA when the brand-design toggle is enabled, while preserving the legacy
DaxNoTrackersCtapath when disabled.Implements
DaxNoTrackersBrandDesignUpdateContextualCtawith the new card content wiring (HTML description text, primary CTA click handling, and a background banner resource), and adds an instrumentation test suite validating toggle-driven selection and pixel firing for shown/OK/close events.Reviewed by Cursor Bugbot for commit d6c77f4. Bugbot is set up for automated code reviews on this repo. Configure here.