Data-clearing additions to delete selected Duck.ai chats#8582
Merged
Conversation
Single(url) is just Selected(setOf(url)) on the data side; collapse the two variants so callers describe the shape in one place. The plugin now batches the sync trigger to one event per user-visible delete action, and empty set is an explicit no-op early return.
Contributor
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
16 tasks
YoussefKeyrouz
approved these changes
May 15, 2026
Collaborator
YoussefKeyrouz
left a comment
YoussefKeyrouz
left a comment
There was a problem hiding this comment.
LGTM! matches the API proposal
This was referenced May 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/1/137249556945/task/1214837464091621
Description
Merges
ClearableData.DuckChats.Single(chatUrl: String)into a newSelected(chatUrls: Set<String>)variant in:data-clearing-api.Steps to test this PR
Existing in-chat fire flow is unchanged
chatID=URL.Contextual chat clear is unchanged
UI changes
n/a
Note
Medium Risk
Updates the data-clearing API and DuckChat clearing plugin to accept sets of chat URLs, which could affect chat deletion/sync triggering if callers pass unexpected URLs or empty sets.
Overview
Duck.ai chat clearing now supports subsets of chats instead of only a single URL.
ClearableData.DuckChats.Singleis replaced byClearableData.DuckChats.Selected(Set<String>), and call sites (e.g., single-tab fire/contextual chat clear) now passsetOf(tabUrl).The DuckChat data-clearing plugin is updated to delete each selected chat, record per-chat deletions for sync, and batch sync triggering to a single
DATA_CHANGEevent for the whole selection; tests are updated/expanded to cover multi-delete and empty-set no-op behavior.Reviewed by Cursor Bugbot for commit 42023af. Bugbot is set up for automated code reviews on this repo. Configure here.