Wire per-row Pin/Unpin in chat history overflow menu#8604
Open
GerardPaligot wants to merge 2 commits into
Open
Wire per-row Pin/Unpin in chat history overflow menu#8604GerardPaligot wants to merge 2 commits into
GerardPaligot wants to merge 2 commits into
Conversation
Surfaces a snackbar after the per-row Pin/Unpin overflow action so the user can recover from a mistap. The toggle still fires immediately; the snackbar is purely informational + an Undo affordance that re-issues setPinned with the previous value. Also fixes a pre-existing build break in RecordingRenameRepository, which was missing the setPinned override added in b3157b9.
Contributor
Author
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
This was referenced May 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Task/Issue URL: https://app.asana.com/1/137249556945/project/72649045549333/task/1214820120386824?focus=true
Description
Wires the Pin / Unpin action on the Duck.ai chat history screen so a chat actually moves between the Pinned and Recent sections. The toggle fires immediately with no confirmation; a snackbar with Undo appears so a mistap is recoverable. State is persisted via the native chat store so the same Pinned/Recent split shows on next open and on Duck.ai itself.
Steps to test this PR
Note
Prerequisites:
duckAiChatHistory(self,historyScreen) is ON andduckChat → useNativeStorageChatDatais ON.Happy path
Persistence
UI changes
Note
Medium Risk
Adds new pin/unpin write path that mutates stored chat JSON and updates UI ordering; mistakes could cause incorrect pinned state or lost updates across sessions.
Overview
Enables Pin/Unpin from the chat history row overflow menu: the action now toggles a chat between Pinned and Recent and shows a snackbar with Undo.
This adds a
setPinnedpersistence API throughChatHistoryRepositoryintoDuckAiChatStore(writing thepinnedflag into the stored JSON), introduces aMessageEvent.PinToggledstream for snackbar messaging, and adds new strings plus unit tests covering toggle/undo and store JSON updates.Reviewed by Cursor Bugbot for commit 23dda12. Bugbot is set up for automated code reviews on this repo. Configure here.