Comments menu

[fizi]

If I change the settings and enter the language-specific title in the title field, the system indicates that it has been saved, but nothing changes; it continues to display the title in English and uses the default settings. I am unable to change the settings via the admin interface.

[tgtje]

Long time i looked at its working.. I can confirm this behaviour ( v2.3.12 + Master).
Multifield in menu > basic title is there (EN), switch Language to another > you would need to add a title (caption) ok save.
From there directly to main to see "yes present in my lang : switching to English ( main again ( via userl menu or admin) NO caption
In short it will remember only last input in language used.
Language activated table copies > no change in behaviour.

[tgtje]

Had an idea : checking ( 2.3.12 dd 5 sept) master 12 sept) above mentioned running php 8.3.14 + 8.5.16)
Using php 8.1.31 on 2.3.12 :
Fatal error: Uncaught Error: Undefined constant "USERLV" in C:\wamp64\www\235naar239\e107_handlers\comment_class.php on line 500
on page Content eg Article 1 (comment allowed) this error.
relationship with recently discussion #6355 (and #6378 ?)

this one now keeps pop up :
Warning Undefined array key "user_name", Line 4924 of c:\wamp64\www\coredefine\e107_handlers\e_parse_class.php
On both versions after switching the php versions (Note not updated to latest master (2-3 days old) Not seen before.
Sorry 😶

[fizi]

I switching to english and add the title - after this I switching to hungarian and add the title. It looks like it’s been rewritten now, but this isn't right.

[e107help[bot]]

Helló @fizi,

The screen cannot hold two languages at the moment, and no setting changes that. I reproduced it on a fresh master site and filed it as #6490. What you saw at the end, the English title being overwritten by the Hungarian one, is the whole bug: the field posts as comment_caption[Hungarian], and the save replaces the entire stored caption with that one entry instead of adding to it. The language that lost its entry then gets no heading at all on the front end, not even the default "Comments".

In the meantime, the caption you can control is in your theme. At the top of your theme's tablestyle(), before it prints the heading, using whatever name your theme gives the third argument ($mode in bootstrap5, $id in some older themes):

if($mode === 'comment_menu' && empty($caption))
{
	$caption = defset('LAN_COMMENTS', 'Comments');
}

LAN_COMMENTS comes from the language pack, so the visitor gets it in their own language, and the second argument is what shows if a pack lacks it. Leave the caption field on the screen empty in both languages and the theme fills it in. Swap it for any text of your own if you would rather not use the pack's word.

@tgtje, thank you for the two versions and the PHP switch, and sorry it bit you. Switch "Display new comment icon" off (Comments admin, Preferences tab) and the fatal stops; that is the only preference that reaches the line. Filed as #6491. With it on, the comment list compares each comment's date with USERLV, a constant that exists only for a signed-in visitor, so a guest hits the fatal on any item with a comment while an admin sees the page render. Both your runs are PHP 8, so the likelier difference between them is being signed in on one and not on the other. The user_name warning at line 4924 is the guest comment form handing the avatar renderer no user, and it is in the same issue.