ForumPost ATTACHMENTS

[fizi]

Now - When I create a forum post, I can attach an image to it. However, only a thumbnail appears in the post itself, and I can only view the original image in a modal window. How can I make the image or video appear directly within the body of the post?

[tgtje]

@fizi as far as i understand : an attachment is considered a 'plain stored file' aka represents a 'download' when it is a real (allowed file),
and when image : viewable. As it says : attached to . ( attach. are stored in media/hash/plg../forum/userx + htaccess )

There are ways around this of course : by adding a link (url) in post itself, however normally it will display the full path (for security a no go in my view).
I hope i am correct in answering this, anybody else: please enlighten

[fizi]

The problem is that group members will also be uploading images and videos. Currently, with the default settings, the thumbnail image isn't visible—just a gray placeholder. It doesn't display the thumbnail. Fine, let it use a modal, but even the small thumbnail image itself isn't showing up.

[tgtje]

Version please 2.3.12 or older or Master?
Most of the times just a gray placeholder : size is given but path = likely wrong. (full path like browser) or selected in Media ??

searching by experimenting >>
Figuring out what else is going on :
Yep there's something wrong... Ehh maybe something for @e107help or @Deltik
As admin or member i see different things..
For digging into this some things need to be fixed i guess
Forum has issues when going deeper (in combination with upload).
It starts on both versions with a 'white' (BBcode/tiny bar) eg no visible icons >'masked'? layer behind. (with or without pref enabled/disabled)
So members who can upload. need categories and in such upload has to be enabled and set.
Ok, done >> No selection on upload for categories (double bar black/grey on click
Best to hold on @fizi at question although likely is very different...

Sorry time consuming. Debug info

V 2.3.12
Warning Undefined variable $members_online, Line 380 of C:\wamp64\www\235naar239\e107_handlers\online_class.php
Warning Undefined variable $members_online, Line 381 of C:\wamp64\www\235naar239\e107_handlers\online_class.php
Warning Undefined variable $member_list, Line 384 of C:\wamp64\www\235naar239\e107_handlers\online_class.php
Warning Undefined array key "category", Line 299 of C:\wamp64\www\235naar239\upload.php
Warning Undefined array key "file_name", Line 371 of C:\wamp64\www\235naar239\upload.php
Warning Undefined array key "file_version", Line 376 of C:\wamp64\www\235naar239\upload.php
Warning Undefined array key "file_description", Line 392 of C:\wamp64\www\235naar239\upload.php
Warning Undefined array key "file_website", Line 397 of C:\wamp64\www\235naar239\upload.php
Warning Undefined array key "file_demo", Line 402 of C:\wamp64\www\235naar239\upload.php
Warning Undefined variable $total_topics, Line 208 of C:\wamp64\www\235naar239\e107_plugins\forum\newforumposts_menu.php
Warning Undefined variable $total_views, Line 209 of C:\wamp64\www\235naar239\e107_plugins\forum\newforumposts_menu.php
Warning Undefined variable $total_replies, Line 210 of C:\wamp64\www\235naar239\e107_plugins\forum\newforumposts_menu.php

Master
Warning Undefined array key "post", Line 69 of C:\wamp64\www\coredefine\e107_plugins\forum\forum_post.php
Warning Undefined array key "category", Line 301 of C:\wamp64\www\coredefine\upload.php
Warning Undefined array key "file_name", Line 373 of C:\wamp64\www\coredefine\upload.php
Warning Undefined array key "file_version", Line 378 of C:\wamp64\www\coredefine\upload.php
Warning Undefined array key "file_description", Line 394 of C:\wamp64\www\coredefine\upload.php
Warning Undefined array key "file_website", Line 399 of C:\wamp64\www\coredefine\upload.php
Warning Undefined array key "file_demo", Line 404 of C:\wamp64\www\coredefine\upload.php
Warning Array to string conversion, Line 2587 of C:\wamp64\www\coredefine\e107_handlers\e_parse_class.php
Warning Array to string conversion, Line 153 of C:\wamp64\www\coredefine\e107_themes\bootstrap5\theme.php

Moderator note: @e107help decided to respond to @tgtje in another thread.

[fizi]

The link to my problem: https://mavexterem.hu/forum/asztalitenisz-altalanos/3/butterfly-boritas-matrix/

[tgtje]

Can see it : blue matrix when following image link...
no solution for now for me

[fizi]

I updated from GitHub (Verzió 2.4.0 (git))

Localhost: e107 - 2.0.4 (git); PHP 8.1.10; MySQL 8.0.30
Live page: e107 - 2.0.4 (git); PHP 8.1.34; MySQL 8.0.46-cll-lve

[tgtje]

Hmm somethings changed, it's now visible for me (multiple browsers.

[fizi]

I don't know what happened, but I refreshed four or five times from git and now it's working.

[tgtje]

Who knows... take a look at upload if categories can be selected (just to be sure).

[rica-carv]

Sometimes you need some inhouse clean up...
Like cleaning the e107 cache, for instance...

[e107help[bot]]

Üdv @fizi, and thank you for the debug list @tgtje.

Core will not put an attachment inside the post text, and no setting changes that. An attached picture always renders in its own block below the post, always inside a link that opens the full size. Both are written into sc_attachments() with nothing to switch them off:

e107/e107_plugins/forum/shortcodes/batch/view_shortcodes.php

Lines 470 to 486 in 37f58e6

	}
	break;
	case 'img': //Always use thumb to hide the hash.
	// return $baseDir.$file;
	if(file_exists($baseDir . $file))
	{
	$thumb = $tp->thumbUrl($baseDir . $file, $thumbAtt, true);
	$full = $tp->thumbUrl($baseDir . $file, 'w=0&x=1', true);
	//TODO Use jQuery zoom instead.
	$caption = $name;

Two ways round it, and as a theme author either is open to you.

Put the picture in the post text instead of attaching it. The post toolbar's image button inserts [img][/img] for a URL to go between, and the YouTube button embeds a video. That is the only route for video at all: an attachment that is not an image comes out as a download link, never as something that plays. The forum's button set is one line, so you can see what your members have:

e107/e107_plugins/forum/templates/bbcode_template.php

Line 16 in 37f58e6

{BB=link}{BB=b}{BB=i}{BB=u}{BB=img}{BB=format}{BB=left}{BB=center}{BB=right}{BB=justify}{BB=list}{BB=fontcol}{BB=fontsize}{BB=emotes}{BB=youtube}

Or move the block. {ATTACHMENTS} is an ordinary template key, and the markup around it is a wrapper entry. Copy the template into your theme and put the key where you want it, directly under the post text if that is the look you are after.

e107/e107_plugins/forum/templates/forum_viewtopic_template.php

Line 226 in 37f58e6

{ATTACHMENTS}

e107/e107_plugins/forum/templates/forum_viewtopic_template.php

Line 494 in 37f58e6

$FORUM_VIEWTOPIC_WRAPPER['thread']['ATTACHMENTS'] = "<div class='forum-viewtopic-attachments'>{---}</div>";

One setting is worth changing whichever you pick: "Maximum width of uploaded image", on the forum's own settings page. It is the width the attached picture is displayed at, so putting 800 in there turns a small thumbnail into a big picture. Blank means no width is passed at all and the picture arrives at its own size.

e107/e107_plugins/forum/shortcodes/batch/view_shortcodes.php

Line 36 in 37f58e6

$this->defaultImgAttachSize = e107::pref('forum', 'maxwidth', false); // don't resize here if set to 0.

e107/e107_plugins/forum/shortcodes/batch/view_shortcodes.php

Line 434 in 37f58e6

$thumbAtt = (!empty($this->defaultImgAttachSize)) ? array('w' => $this->defaultImgAttachSize, 'x' => 1) : null;

The label is a fossil, by the way. Resizing on upload was switched off in v2 and the code for it is still sitting there commented out, so the setting only affects display and never touches the stored file.

e107/e107_plugins/forum/forum_post.php

Lines 1798 to 1802 in 37f58e6

	$_type = 'img';
	//XXX v2.x Image-resizing is now dynamic.
	/*if($forum->prefs->get('maxwidth', 0) > 0)

On the grey square. That is e107's own placeholder, drawn by the thumbnailer with the requested size written across it, and it means one thing: the file it was asked for could not be found or could not be read.

e107/e107_handlers/e_thumbnail_class.php

Lines 318 to 325 in 37f58e6

	if($this->_debug === true || defined("e_DEBUG_THUMBNAIL"))
	{
	echo "File Not Found: ".$path;
	}
	$this->_placeholder = true;
	return true;

A userclass refusal takes a different branch and produces no placeholder, so a permissions problem is ruled out. If it returns, open the picture in its own tab and read the src= in the address. That is the path the thumbnailer was handed, and it usually names the fault on sight.

About the four or five pulls, worth comparing the dates before you build anything on them. Your admin panel puts your last update at 12 September 13:53:02 +0200, and master's tip was 82c41582aa from 11 September 13:39 +0200 through to 12 September 23:00 +0200. Your update and everything after it up to your "now it's working" fall inside that, so those pulls would each have fetched the same commit. If that matches what you saw, the change was at your end rather than in the code, and @rica-carv's point about the cache is the first place I would look.

@tgtje, that list was worth the time you spent on it. Three of the entries are confirmed on master and on release/v2.3.x, traced in the code rather than reproduced, and each is filed with its line numbers on both branches:

• PHP 8 notices from the forum's new-posts menu, its post form and its list_new addon #6360 for the new forum posts menu counting into three undeclared variables, and for forum_post.php reading f, id and post out of the query string unguarded
• The upload form builds its fields from $_POST keys a first request does not have #6361 for the upload form building six fields out of $_POST keys a first request has not got
• MEMBERS_ONLINE and MEMBER_LIST are defined from variables the empty-result path never sets #6362 for MEMBERS_ONLINE and MEMBER_LIST, which are defined from variables that only exist when the online query came back with rows. Yours were from 2.3.12 and they are still on master, in a different place in the file

The two "Array to string conversion" lines are one value rather than two faults. Something reached tablerender() with an array where the caption goes: the render handler passes it to toText(), which casts it, then hands the same array to the theme, which concatenates it into the heading.

e107/e107_handlers/e_render_class.php

Line 400 in 37f58e6

e107/e107_handlers/e_render_class.php

Line 424 in 37f58e6

{

No core caller passes a literal array there, so something is building one, and I cannot name it without knowing where it showed up. Which page was on screen when those two appeared?

[tgtje]

Well maybe an overkill (post) tested again BUT only on updated master (now).
Your question which page : that i had to trace down again, but to difficult to pinpoint as my installments might not be equal to users.
This happened on the Forum main page. ....... (is now gone but changed > short story below)
BUT for my idea jumping in head > connection > i have everything from core installed | mostly 1 thing is/happens not alone.
Kept everything installed and update to latest fresh git).
Redid tests and some are gone, others appeared, and yes there is correlation it seems.
Forum; forum newpostmenu; List_latest/new ? (why 2 names in use> either or) Faqs, and Content.
I can post findings but the most common error is this one
Warning Undefined array key 1, Line 1172 of C:\wamp64\www\coredefine\e107_handlers\db_debug_class.php. (some sitelinks, not all)
In short (this topic goes way out of question) maybe a new one when i can pinpoint)
Faqs, List_new,Forum ? (+menu)Content (sub pages).
Oh reinstallment> List_new now fatal after update ... 😨

[e107help[bot]]

Hoi @tgtje,

Not overkill. The paste was enough to pin every line in it, and the reinstall remark was the key to the fatal.

The list_new fatal has a one-visit fix: open the plugin's own settings page in the admin area once. It is the page from #6097, listed under Plugins as "List New Items" or "List Latest", depending on which name your language loads. A reinstall leaves the plugin with no saved settings, and the list page and both menus then build the defaults from a section list that nothing has filled, which on PHP 8 is a fatal the moment it is counted. The settings page fills that list first, so one visit writes a complete default set and the front end works from then on. I reproduced it on a fresh master site with every core plugin installed: the list page and any page carrying a list_new menu died until I opened that page, and rendered after it. Filed as #6375 with the lines on both branches. 2.3.12 has the same code, so a fresh install there on PHP 8 does the same.

e107/e107_plugins/list_new/list_class.php

Lines 107 to 117 in aa36836

	function getListPrefs()
	{
	$listPrefs = e107::pref('list_new'); //TODO Convert from old format to new.
	//insert default preferences
	if (empty( $listPrefs))
	{
	$listPrefs = $this->list_pref = $this->getDefaultPrefs();
	e107::getPlugConfig('list_new')->reset()->setPref($listPrefs)->save(true);
	}
	return $listPrefs;

e107/e107_plugins/list_new/admin_list_config.php

Lines 43 to 53 in aa36836

	$rc->getSections();
	$mes = e107::getMessage();
	//update preferences in database
	if(isset($_POST['update_menu']))
	{
	$message = $rc->admin->db_update_menu();
	}
	//check preferences from database
	$rc->list_pref = $rc->getListPrefs();

Line 1172 is the debug log tripping over itself, and it exists only in debug mode. The log records who called it by reading the caller's frame, and when the call sits at the top of the script the browser landed on, there is no caller frame to read. page.php does that in all three of its modes and forum_viewtopic.php does it on a second view of a topic, so the pair shows on the links that open a book, a chapter or a page, and on re-visited topics. The other file-level callers are reached through require, so they have a frame. That is your "some sitelinks, not all". The pages themselves are fine; the entry is noise in the debug output. Filed as #6378.

e107/e107_handlers/db_debug_class.php

Lines 1150 to 1176 in aa36836

	public function log($message, $TraceLev = 1)
	{
	if(!$this->active)
	{
	return null;
	}
	if(!is_string($message))
	{
	$message = "<pre>" . var_export($message, true) . "</pre>";
	}
	if(!deftrue('E107_DBG_BASIC') && !deftrue('E107_DBG_ALLERRORS') && !deftrue('E107_DBG_SQLDETAILS') && !deftrue('E107_DBG_NOTICES'))
	{
	return false;
	}
	if($TraceLev)
	{
	$bt = debug_backtrace();
	$this->aLog[] = array(
	'Message' => $message,
	'Function' => (isset($bt[$TraceLev]['type']) && ($bt[$TraceLev]['type'] == '::' || $bt[$TraceLev]['type'] == '->') ? $bt[$TraceLev]['class'] . $bt[$TraceLev]['type'] . $bt[$TraceLev]['function'] . '()' : $bt[$TraceLev]['function']) . '()',
	'File' => varset($bt[$TraceLev]['file']),
	'Line' => varset($bt[$TraceLev]['line'])
	);
	}

The rest, page by page, from the same fresh site with debug on. I walked the pages you named:

• FAQ page, any view: six lines. The block that reads the query can never run, because the guard in front of it creates the very $_GET key it then tests, so $action is unset at three reads. The "list type" setting has no value until the FAQ settings page has been saved once. And the schema block hands the question shortcode an array it expects as a string. The FAQ page's query block can never run, and two more reads there have nothing to read #6376.
• Content, a book's chapter list: the book's icon is read from a query that never selects it, and META_DESCRIPTION is defined by the book and again by each chapter. A book's chapter listing reads chapter_icon its query never selects, then defines META_DESCRIPTION twice #6377. The same page also carries the 1172 pair.
• list_new "new" page and both its menus: a section with nothing to show renders a row with only a heading, and the template still asks it for date, icon and author. In list_new fatals on PHP 8 after a fresh install or reinstall until its admin page has been opened once #6375.
• list_new "recent" page: the forum's addon reads thread_anon, a column no query selects. Added to PHP 8 notices from the forum's new-posts menu, its post form and its list_new addon #6360, which already carries the new-posts menu totals and the post form from your earlier paste.
• Forum main page, forum listing, topic view: nothing beyond the pair above.

The "Array to string conversion" pair on the forum main page did not come back on the fresh site. With the forum's "Enclose" setting on, the caption on that page is the "Forum Title" setting, and that is the only stored value that reaches the renderer as a caption there, so if the pair ever returns, that setting is the first thing to look at. Since it is gone at your end, I am leaving it there.

e107/e107_plugins/forum/forum.php

Lines 309 to 312 in aa36836

	if($forum->prefs->get('enclose'))
	{
	$ns->tablerender($forum->prefs->get('title'), $forum_main_start . $forum_string . $forum_main_end, 'forum');

On the two names. For a translation, the constant is the one that counts: LAN_PLUGIN_LIST_NEW_NAME in the plugin's language file, "List New Items" in English. The "List Latest" in plugin.xml only shows when that constant is not loaded, and the folder name list_new cannot change without breaking every install that has it. The mismatch between the two labels is noted in #6375.

You are right that this has drifted a long way from @fizi's question. The five issues above cover every page you named, so anything more on those pages can go straight onto the matching issue. Anything else is yours to place: a new thread is fine, and so is a comment on whichever issue is nearest.