Skip to content

Merge dev/refactor_create_seal_shard into stable/v4.x#449

Merged
Hooper9973 merged 7 commits into
eBay:stable/v4.xfrom
Hooper9973:merge_dev_refactor_shard
Jul 7, 2026
Merged

Merge dev/refactor_create_seal_shard into stable/v4.x#449
Hooper9973 merged 7 commits into
eBay:stable/v4.xfrom
Hooper9973:merge_dev_refactor_shard

Conversation

@Hooper9973

Copy link
Copy Markdown
Contributor

No description provided.

…O, add prod repro issue (eBay#434)

SDSTOR-21981: make shard create/seal log-only, avoid header/footer I/O, add prod repro issue

  - Switch create_shard and seal_shard to log-only; remove data channel path
  - Stop persisting shard header/footer on disk for create/seal flows
  - Add production GC issue reproductions:
    - issue1: concurrent seal_shard, create_shard, and GC
    - issue2: concurrent put_blob and seal_shard can place blob into sealed shard
…tor (eBay#438)

- Migrate v2 shard superblk (sb_version=0x02) to v3 on recovery; unify decode
logic into decode_shard_sb() shared by raft-log path and on_shard_meta_blk_found

- Decode old shard raft-log messages (v2 header_extn) on new code path; extend
ResyncShardMetaData schema with sealed_lsn at end for old-buffer compat

- Override get_blk_alloc_hint for CREATE/SEAL_SHARD to return committed-blk hint,
skipping data-block allocation for log-only shard messages

@xiaoxichen xiaoxichen left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please do squash merge

@JacksonYao287 JacksonYao287 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Comment thread conanfile.py
class HomeObjectConan(ConanFile):
name = "homeobject"
version = "4.1.24"
version = "4.2.3"

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

4.2.1?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It doesn't matter~


// Schema snapshot of ResyncShardMetaData before sealed_lsn was added.
// Used only in compatibility tests to produce old-format buffers.
table ResyncLegacyShardMetaData {

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we can remove this after we upgrade to 0.5.6, right?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Correct, we can remove this after upgrading all the clusters online

@codecov-commenter

Copy link
Copy Markdown

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

❌ Patch coverage is 40.40404% with 118 lines in your changes missing coverage. Please review.
⚠️ Please upload report for BASE (stable/v4.x@0240b59). Learn more about missing BASE report.

Files with missing lines Patch % Lines
src/lib/homestore_backend/gc_manager.cpp 0.00% 57 Missing ⚠️
src/lib/homestore_backend/hs_shard_manager.cpp 59.13% 32 Missing and 6 partials ⚠️
...ib/homestore_backend/replication_state_machine.cpp 18.18% 9 Missing ⚠️
src/lib/homestore_backend/hs_blob_manager.cpp 66.66% 4 Missing and 2 partials ⚠️
src/lib/homestore_backend/hs_http_manager.cpp 0.00% 6 Missing ⚠️
src/lib/homestore_backend/heap_chunk_selector.cpp 71.42% 2 Missing ⚠️
❗ Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@              Coverage Diff               @@
##             stable/v4.x     #449   +/-   ##
==============================================
  Coverage               ?   47.82%           
==============================================
  Files                  ?       36           
  Lines                  ?     5355           
  Branches               ?      674           
==============================================
  Hits                   ?     2561           
  Misses                 ?     2539           
  Partials               ?      255           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Hooper9973 Hooper9973 merged commit 4b25833 into eBay:stable/v4.x Jul 7, 2026
71 of 73 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants