Change task_id to string - #758
Merged
Merged
Conversation
|
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #758 +/- ##
==========================================
- Coverage 56.51% 55.69% -0.82%
==========================================
Files 108 109 +1
Lines 10300 12632 +2332
Branches 1402 1801 +399
==========================================
+ Hits 5821 7036 +1215
- Misses 3894 4840 +946
- Partials 585 756 +171 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
yuwmao
force-pushed
the
taskid
branch
2 times, most recently
from
June 27, 2025 03:25
4bee185 to
ac8c280
Compare
xiaoxichen
previously approved these changes
Jun 27, 2025
Besroy
approved these changes
Jun 27, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changing task_id to string allows users to use more meaningful information as id.
In NuObject2.0, CM will use "timestamp:pg_id" as task_id for easy time based range query in its kvstore.