Skip to content

Change task_id to string - #758

Merged
yuwmao merged 1 commit into
eBay:masterfrom
yuwmao:taskid
Jun 27, 2025
Merged

Change task_id to string#758
yuwmao merged 1 commit into
eBay:masterfrom
yuwmao:taskid

Conversation

@yuwmao

@yuwmao yuwmao commented Jun 26, 2025

Copy link
Copy Markdown
Contributor

Changing task_id to string allows users to use more meaningful information as id.
In NuObject2.0, CM will use "timestamp:pg_id" as task_id for easy time based range query in its kvstore.

@yuwmao
yuwmao requested a review from JacksonYao287 June 26, 2025 03:42
@codecov-commenter

codecov-commenter commented Jun 26, 2025

Copy link
Copy Markdown

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 0% with 31 lines in your changes missing coverage. Please review.

Project coverage is 55.69%. Comparing base (1a0cef8) to head (0e29dfc).
Report is 221 commits behind head on master.

Files with missing lines Patch % Lines
src/lib/replication/repl_dev/raft_repl_dev.cpp 0.00% 20 Missing ⚠️
src/lib/replication/repl_dev/raft_repl_dev.h 0.00% 7 Missing ⚠️
src/lib/replication/service/generic_repl_svc.cpp 0.00% 2 Missing ⚠️
src/lib/replication/service/raft_repl_service.cpp 0.00% 2 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #758      +/-   ##
==========================================
- Coverage   56.51%   55.69%   -0.82%     
==========================================
  Files         108      109       +1     
  Lines       10300    12632    +2332     
  Branches     1402     1801     +399     
==========================================
+ Hits         5821     7036    +1215     
- Misses       3894     4840     +946     
- Partials      585      756     +171     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Besroy
Besroy previously approved these changes Jun 26, 2025

@Besroy Besroy left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yuwmao
yuwmao force-pushed the taskid branch 2 times, most recently from 4bee185 to ac8c280 Compare June 27, 2025 03:25
xiaoxichen
xiaoxichen previously approved these changes Jun 27, 2025
@yuwmao
yuwmao merged commit 327ab32 into eBay:master Jun 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants