Skip to content

Join ddsrouter_utils and ddsourter_event - #240

Merged
rsanchez15 merged 3 commits into
mainfrom
refactor/utils-events
Jun 20, 2022
Merged

Join ddsrouter_utils and ddsourter_event#240
rsanchez15 merged 3 commits into
mainfrom
refactor/utils-events

Conversation

@jparisu

@jparisu jparisu commented Jun 17, 2022

Copy link
Copy Markdown
Contributor

Signed-off-by: jparisu javierparis@eprosima.com

@jparisu jparisu mentioned this pull request Jun 17, 2022
@jparisu
jparisu temporarily deployed to codecov June 17, 2022 10:13 Inactive
@jparisu
jparisu temporarily deployed to codecov June 17, 2022 10:13 Inactive
@jparisu
jparisu temporarily deployed to codecov June 17, 2022 10:13 Inactive
Comment thread docs/rst/notes/notes.rst
* New DDS Router library that provides the DDS Router features through a C++ API.
* Division of DDS Router application into several packages.

- `ddsrouter_event`: C++ library which implements System Operating (SO)-dependent signal handlers.

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Be careful here. Do not remove it from previous versions. Also add a comment in Forthcoming version

@codecov

codecov Bot commented Jun 17, 2022

Copy link
Copy Markdown

Codecov Report

Merging #240 (577cf8f) into main (879a193) will decrease coverage by 0.12%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #240      +/-   ##
==========================================
- Coverage   59.32%   59.20%   -0.13%     
==========================================
  Files          91       91              
  Lines        3157     3157              
  Branches     1141     1141              
==========================================
- Hits         1873     1869       -4     
- Misses        592      593       +1     
- Partials      692      695       +3     
Impacted Files Coverage Δ
...ils/include/ddsrouter_utils/event/EventHandler.hpp 100.00% <ø> (ø)
...clude/ddsrouter_utils/event/SignalEventHandler.hpp 100.00% <ø> (ø)
...nclude/ddsrouter_utils/event/impl/EventHandler.ipp 79.36% <ø> (ø)
.../ddsrouter_utils/event/impl/SignalEventHandler.ipp 75.00% <ø> (ø)
...clude/ddsrouter_utils/event/impl/SignalManager.ipp 72.88% <ø> (ø)
...nclude/ddsrouter_utils/wait/BooleanWaitHandler.hpp 0.00% <ø> (ø)
...clude/ddsrouter_utils/wait/ConsumerWaitHandler.hpp 0.00% <ø> (ø)
...ls/include/ddsrouter_utils/wait/IntWaitHandler.hpp 0.00% <ø> (ø)
.../ddsrouter_utils/wait/impl/ConsumerWaitHandler.ipp 89.47% <ø> (ø)
...e/ddsrouter_utils/wait/impl/DBQueueWaitHandler.ipp 82.35% <ø> (ø)
... and 15 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 879a193...577cf8f. Read the comment docs.

@jparisu
jparisu temporarily deployed to codecov June 17, 2022 10:24 Inactive
@jparisu
jparisu temporarily deployed to codecov June 17, 2022 11:16 Inactive
@jparisu
jparisu temporarily deployed to codecov June 17, 2022 11:16 Inactive
@jparisu
jparisu temporarily deployed to codecov June 17, 2022 11:16 Inactive

@rsanchez15 rsanchez15 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please rebase before merging

@rsanchez15 rsanchez15 changed the title Join ddsrouter_utils and ddsourte_event Join ddsrouter_utils and ddsourter_event Jun 20, 2022
jparisu added 3 commits June 20, 2022 08:04
Signed-off-by: jparisu <javierparis@eprosima.com>
Signed-off-by: jparisu <javierparis@eprosima.com>
Signed-off-by: jparisu <javierparis@eprosima.com>
@jparisu
jparisu force-pushed the refactor/utils-events branch from 1a15326 to 577cf8f Compare June 20, 2022 06:04
@jparisu
jparisu temporarily deployed to codecov June 20, 2022 06:04 Inactive
@jparisu
jparisu temporarily deployed to codecov June 20, 2022 06:04 Inactive
@jparisu
jparisu temporarily deployed to codecov June 20, 2022 06:04 Inactive
@rsanchez15
rsanchez15 merged commit 7b45dab into main Jun 20, 2022
@rsanchez15
rsanchez15 deleted the refactor/utils-events branch June 20, 2022 06:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants