[15012]: Bug fix, small refactor and tests in TlsConfiguration - #244
Merged
Conversation
Signed-off-by: Anton Rey <aanton.rv@gmail.com>
Signed-off-by: Anton Rey <aanton.rv@gmail.com>
Signed-off-by: Anton Rey <aanton.rv@gmail.com>
Signed-off-by: Anton Rey <aanton.rv@gmail.com>
Codecov Report
@@ Coverage Diff @@
## main #244 +/- ##
==========================================
+ Coverage 58.88% 59.31% +0.42%
==========================================
Files 93 91 -2
Lines 3223 3200 -23
Branches 1181 1188 +7
==========================================
Hits 1898 1898
+ Misses 599 574 -25
- Partials 726 728 +2
Continue to review full report at Codecov.
|
jparisu
suggested changes
Jun 28, 2022
jparisu
left a comment
Contributor
There was a problem hiding this comment.
Cool and elegant Implementation 👍
Just minor suggestions.
Signed-off-by: Anton Rey <aanton.rv@gmail.com>
jparisu
reviewed
Jun 28, 2022
jparisu
left a comment
Contributor
There was a problem hiding this comment.
Everything LGTM,
Windows fails linking new methods nevertheless.
Collaborator
|
Do not forget to add this bugfix to the release notes. |
rsanchez15
self-requested a review
June 28, 2022 13:57
Signed-off-by: Anton Rey <aanton.rv@gmail.com>
Signed-off-by: Anton Rey <aanton.rv@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug fix according to reported issue: TLS config for both server and client does not work #243
Small refactor to simplify TlsConfiguration architecture (bloated class hierarchy, unneeded polymorphism)
New tests for previously untested scenarios