Skip to content

[15012]: Bug fix, small refactor and tests in TlsConfiguration - #244

Merged
jparisu merged 7 commits into
mainfrom
fix/tls-config
Jun 28, 2022
Merged

[15012]: Bug fix, small refactor and tests in TlsConfiguration#244
jparisu merged 7 commits into
mainfrom
fix/tls-config

Conversation

@antonrv

@antonrv antonrv commented Jun 28, 2022

Copy link
Copy Markdown
Contributor

antonrv added 4 commits June 28, 2022 11:52
Signed-off-by: Anton Rey <aanton.rv@gmail.com>
Signed-off-by: Anton Rey <aanton.rv@gmail.com>
Signed-off-by: Anton Rey <aanton.rv@gmail.com>
Signed-off-by: Anton Rey <aanton.rv@gmail.com>
@antonrv
antonrv temporarily deployed to codecov June 28, 2022 09:55 Inactive
@antonrv
antonrv temporarily deployed to codecov June 28, 2022 09:55 Inactive
@codecov

codecov Bot commented Jun 28, 2022

Copy link
Copy Markdown

Codecov Report

Merging #244 (55e2f37) into main (ce4904f) will increase coverage by 0.42%.
The diff coverage is 66.21%.

@@            Coverage Diff             @@
##             main     #244      +/-   ##
==========================================
+ Coverage   58.88%   59.31%   +0.42%     
==========================================
  Files          93       91       -2     
  Lines        3223     3200      -23     
  Branches     1181     1188       +7     
==========================================
  Hits         1898     1898              
+ Misses        599      574      -25     
- Partials      726      728       +2     
Impacted Files Coverage Δ
ddsrouter_yaml/src/cpp/YamlReader.cpp 42.28% <16.66%> (+0.56%) ⬆️
...entations/rtps/impl/DiscoveryServerParticipant.ipp 47.88% <47.05%> (-0.03%) ⬇️
...cipant/DiscoveryServerParticipantConfiguration.cpp 48.93% <66.66%> (+6.34%) ⬆️
...re/src/cpp/types/security/tls/TlsConfiguration.cpp 80.00% <78.57%> (+33.33%) ⬆️
...outer_core/types/security/tls/TlsConfiguration.hpp 100.00% <100.00%> (ø)
ddsrouter_core/src/cpp/efficiency/PayloadPool.cpp 76.47% <0.00%> (-1.97%) ⬇️
ddsrouter_core/src/cpp/communication/Track.cpp 64.86% <0.00%> (+2.70%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ce4904f...55e2f37. Read the comment docs.

@jparisu jparisu left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool and elegant Implementation 👍
Just minor suggestions.

Comment thread ddsrouter_core/src/cpp/types/security/tls/TlsConfiguration.cpp Outdated
Comment thread ddsrouter_core/src/cpp/types/security/tls/TlsConfiguration.cpp Outdated
Signed-off-by: Anton Rey <aanton.rv@gmail.com>
@antonrv
antonrv temporarily deployed to codecov June 28, 2022 12:22 Inactive
@antonrv
antonrv temporarily deployed to codecov June 28, 2022 12:22 Inactive
@antonrv
antonrv temporarily deployed to codecov June 28, 2022 12:42 Inactive
@antonrv
antonrv temporarily deployed to codecov June 28, 2022 12:42 Inactive

@jparisu jparisu left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything LGTM,
Windows fails linking new methods nevertheless.

@antonrv
antonrv temporarily deployed to codecov June 28, 2022 13:46 Inactive
@antonrv
antonrv temporarily deployed to codecov June 28, 2022 13:46 Inactive
@jparisu jparisu linked an issue Jun 28, 2022 that may be closed by this pull request
@rsanchez15

Copy link
Copy Markdown
Collaborator

Do not forget to add this bugfix to the release notes.

@rsanchez15
rsanchez15 self-requested a review June 28, 2022 13:57
Signed-off-by: Anton Rey <aanton.rv@gmail.com>
@antonrv
antonrv temporarily deployed to codecov June 28, 2022 14:02 Inactive
@antonrv
antonrv temporarily deployed to codecov June 28, 2022 14:30 Inactive
@antonrv
antonrv temporarily deployed to codecov June 28, 2022 14:30 Inactive
Signed-off-by: Anton Rey <aanton.rv@gmail.com>
@antonrv
antonrv temporarily deployed to codecov June 28, 2022 15:09 Inactive
@antonrv
antonrv temporarily deployed to codecov June 28, 2022 15:09 Inactive

@jparisu jparisu left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with green CI

@jparisu
jparisu merged commit 717a82a into main Jun 28, 2022
@jparisu
jparisu deleted the fix/tls-config branch June 28, 2022 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

TLS config for both server and client does not work

3 participants