Skip to content

Removing mutex from Track hot-path - #261

Merged
jparisu merged 4 commits into
mainfrom
feature/non-locking-track
Aug 11, 2022
Merged

Removing mutex from Track hot-path#261
jparisu merged 4 commits into
mainfrom
feature/non-locking-track

Conversation

@jparisu

@jparisu jparisu commented Aug 8, 2022

Copy link
Copy Markdown
Contributor

Signed-off-by: jparisu javierparis@eprosima.com

@jparisu
jparisu temporarily deployed to codecov August 8, 2022 10:29 Inactive
@jparisu
jparisu requested a review from antonrv August 8, 2022 10:29
@jparisu
jparisu temporarily deployed to codecov August 8, 2022 10:29 Inactive
@codecov

codecov Bot commented Aug 8, 2022

Copy link
Copy Markdown

Codecov Report

Merging #261 (dd133eb) into main (87fe006) will increase coverage by 0.00%.
The diff coverage is 62.50%.

@@           Coverage Diff           @@
##             main     #261   +/-   ##
=======================================
  Coverage   59.03%   59.03%           
=======================================
  Files          99       99           
  Lines        3354     3347    -7     
  Branches     1247     1246    -1     
=======================================
- Hits         1980     1976    -4     
+ Misses        614      612    -2     
+ Partials      760      759    -1     
Impacted Files Coverage Δ
ddsrouter_core/src/cpp/communication/Track.cpp 60.29% <62.50%> (-1.04%) ⬇️
...nclude/ddsrouter_utils/event/impl/EventHandler.ipp 80.95% <0.00%> (+1.58%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@jparisu
jparisu force-pushed the feature/non-locking-track branch from 8e40add to 49621b9 Compare August 8, 2022 11:20
@jparisu
jparisu temporarily deployed to codecov August 8, 2022 11:20 Inactive
@jparisu
jparisu temporarily deployed to codecov August 8, 2022 11:20 Inactive
@jparisu
jparisu force-pushed the feature/non-locking-track branch from 49621b9 to aad3ffa Compare August 8, 2022 11:20
@jparisu
jparisu force-pushed the feature/non-locking-track branch from aad3ffa to d7af897 Compare August 9, 2022 05:40
@jparisu
jparisu temporarily deployed to codecov August 9, 2022 05:40 Inactive
@jparisu
jparisu temporarily deployed to codecov August 9, 2022 05:40 Inactive
@jparisu
jparisu temporarily deployed to codecov August 9, 2022 05:46 Inactive
@jparisu
jparisu temporarily deployed to codecov August 9, 2022 05:46 Inactive
Comment thread ddsrouter_core/src/cpp/communication/Track.cpp
Comment thread docs/rst/notes/forthcoming_version.rst Outdated
jparisu added 2 commits August 11, 2022 08:52
Signed-off-by: jparisu <javierparis@eprosima.com>
Signed-off-by: jparisu <javierparis@eprosima.com>
@jparisu
jparisu force-pushed the feature/non-locking-track branch from 274b1df to 4dc22c5 Compare August 11, 2022 06:52
@jparisu
jparisu temporarily deployed to codecov August 11, 2022 06:52 Inactive
@jparisu
jparisu temporarily deployed to codecov August 11, 2022 06:52 Inactive
jparisu added 2 commits August 11, 2022 08:53
Signed-off-by: jparisu <javierparis@eprosima.com>
Signed-off-by: jparisu <javierparis@eprosima.com>
@jparisu
jparisu temporarily deployed to codecov August 11, 2022 06:54 Inactive
@jparisu
jparisu temporarily deployed to codecov August 11, 2022 06:54 Inactive
@jparisu
jparisu temporarily deployed to codecov August 11, 2022 06:54 Inactive
@jparisu
jparisu temporarily deployed to codecov August 11, 2022 06:54 Inactive

@juanlofer-eprosima juanlofer-eprosima left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jparisu
jparisu removed the request for review from antonrv August 11, 2022 07:17
@jparisu
jparisu merged commit 36c96d8 into main Aug 11, 2022
@jparisu
jparisu deleted the feature/non-locking-track branch August 11, 2022 07:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants