Skip to content

Refactor Participants so are not templatized by configuration - #263

Merged
jparisu merged 3 commits into
mainfrom
refactor/participant-configuration-template
Aug 10, 2022
Merged

Refactor Participants so are not templatized by configuration#263
jparisu merged 3 commits into
mainfrom
refactor/participant-configuration-template

Conversation

@jparisu

@jparisu jparisu commented Aug 9, 2022

Copy link
Copy Markdown
Contributor

Signed-off-by: jparisu javierparis@eprosima.com

Signed-off-by: jparisu <javierparis@eprosima.com>
@jparisu
jparisu temporarily deployed to codecov August 9, 2022 10:17 Inactive
@jparisu
jparisu temporarily deployed to codecov August 9, 2022 10:17 Inactive
@codecov

codecov Bot commented Aug 9, 2022

Copy link
Copy Markdown

Codecov Report

Merging #263 (12231f6) into main (2c49682) will decrease coverage by 0.08%.
The diff coverage is 78.94%.

@@            Coverage Diff             @@
##             main     #263      +/-   ##
==========================================
- Coverage   59.05%   58.97%   -0.09%     
==========================================
  Files         101       99       -2     
  Lines        3378     3354      -24     
  Branches     1261     1247      -14     
==========================================
- Hits         1995     1978      -17     
- Misses        614      615       +1     
+ Partials      769      761       -8     
Impacted Files Coverage Δ
...pant/implementations/auxiliar/DummyParticipant.cpp 48.64% <ø> (ø)
ddsrouter_core/src/cpp/core/ParticipantFactory.cpp 48.64% <50.00%> (-3.44%) ⬇️
...icipant/implementations/rtps/SimpleParticipant.cpp 75.00% <50.00%> (+25.00%) ⬆️
...mplementations/rtps/DiscoveryServerParticipant.cpp 46.66% <66.66%> (ø)
...ipant/implementations/auxiliar/BaseParticipant.cpp 49.20% <82.35%> (ø)
...icipant/implementations/rtps/CommonParticipant.cpp 58.33% <86.66%> (ø)
...t/implementations/rtps/InitialPeersParticipant.cpp 53.33% <87.50%> (ø)
ddsrouter_core/src/cpp/types/dds/DomainId.cpp 52.38% <100.00%> (-5.52%) ⬇️
... and 5 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@jparisu jparisu mentioned this pull request Aug 10, 2022
4 tasks
Comment thread ddsrouter_core/src/cpp/participant/implementations/rtps/CommonParticipant.hpp Outdated
Signed-off-by: jparisu <javierparis@eprosima.com>
@jparisu
jparisu temporarily deployed to codecov August 10, 2022 09:09 Inactive
@jparisu
jparisu temporarily deployed to codecov August 10, 2022 09:09 Inactive

@juanlofer-eprosima juanlofer-eprosima left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Signed-off-by: jparisu <javierparis@eprosima.com>
@jparisu
jparisu temporarily deployed to codecov August 10, 2022 09:50 Inactive
@jparisu
jparisu temporarily deployed to codecov August 10, 2022 09:50 Inactive

@juanlofer-eprosima juanlofer-eprosima left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jparisu
jparisu merged commit 87fe006 into main Aug 10, 2022
@jparisu
jparisu deleted the refactor/participant-configuration-template branch August 10, 2022 10:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants