Limit RTPS History Depth [15534]#288
Merged
Merged
Conversation
Signed-off-by: Juan López Fernández <juanlopez@eprosima.com>
Signed-off-by: Juan López Fernández <juanlopez@eprosima.com>
Signed-off-by: Juan López Fernández <juanlopez@eprosima.com>
Codecov ReportBase: 58.40% // Head: 58.47% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #288 +/- ##
==========================================
+ Coverage 58.40% 58.47% +0.07%
==========================================
Files 99 99
Lines 3414 3427 +13
Branches 1274 1277 +3
==========================================
+ Hits 1994 2004 +10
Misses 646 646
- Partials 774 777 +3
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Signed-off-by: Juan López Fernández <juanlopez@eprosima.com>
juanlofer-eprosima
force-pushed
the
feature/limit-history-depth
branch
from
August 31, 2022 10:11
1d9680a to
3954701
Compare
MiguelBarro
approved these changes
Aug 31, 2022
MiguelBarro
left a comment
There was a problem hiding this comment.
Now we have synchronous writers using KEEP_LAST and defaulting to 5000.
Remember to update the #287 in order to replace this default config with one matching the user writer.
LGTM
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.