Skip to content

Limit RTPS History Depth [15534]#288

Merged
juanlofer-eprosima merged 5 commits into
mainfrom
feature/limit-history-depth
Aug 31, 2022
Merged

Limit RTPS History Depth [15534]#288
juanlofer-eprosima merged 5 commits into
mainfrom
feature/limit-history-depth

Conversation

@juanlofer-eprosima

Copy link
Copy Markdown
Contributor

No description provided.

Signed-off-by: Juan López Fernández <juanlopez@eprosima.com>
Signed-off-by: Juan López Fernández <juanlopez@eprosima.com>
Signed-off-by: Juan López Fernández <juanlopez@eprosima.com>
Signed-off-by: Juan López Fernández <juanlopez@eprosima.com>
@juanlofer-eprosima
juanlofer-eprosima temporarily deployed to codecov August 31, 2022 09:25 Inactive
@juanlofer-eprosima
juanlofer-eprosima temporarily deployed to codecov August 31, 2022 09:25 Inactive
@codecov

codecov Bot commented Aug 31, 2022

Copy link
Copy Markdown

Codecov Report

Base: 58.40% // Head: 58.47% // Increases project coverage by +0.07% 🎉

Coverage data is based on head (3954701) compared to base (d7d1f83).
Patch coverage: 68.18% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #288      +/-   ##
==========================================
+ Coverage   58.40%   58.47%   +0.07%     
==========================================
  Files          99       99              
  Lines        3414     3427      +13     
  Branches     1274     1277       +3     
==========================================
+ Hits         1994     2004      +10     
  Misses        646      646              
- Partials      774      777       +3     
Impacted Files Coverage Δ
...uter_core/configuration/DDSRouterConfiguration.hpp 100.00% <ø> (ø)
ddsrouter_yaml/src/cpp/YamlReader.cpp 47.05% <0.00%> (-0.30%) ⬇️
...e/src/cpp/configuration/DDSRouterConfiguration.cpp 61.36% <50.00%> (ø)
...mplementations/rtps/DiscoveryServerParticipant.cpp 44.06% <50.00%> (+0.47%) ⬆️
...t/implementations/rtps/InitialPeersParticipant.cpp 50.00% <50.00%> (+0.42%) ⬆️
...icipant/implementations/rtps/SimpleParticipant.cpp 80.00% <50.00%> (+5.00%) ⬆️
...icipant/implementations/rtps/CommonParticipant.cpp 58.82% <66.66%> (+0.49%) ⬆️
ddsrouter_core/src/cpp/core/DDSRouterImpl.cpp 45.34% <100.00%> (+0.34%) ⬆️
ddsrouter_core/src/cpp/core/ParticipantFactory.cpp 48.88% <100.00%> (+3.65%) ⬆️
...ore/src/cpp/writer/implementations/rtps/Writer.cpp 63.85% <100.00%> (+1.35%) ⬆️
... and 3 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@juanlofer-eprosima
juanlofer-eprosima temporarily deployed to codecov August 31, 2022 09:51 Inactive
@juanlofer-eprosima
juanlofer-eprosima temporarily deployed to codecov August 31, 2022 09:51 Inactive
Signed-off-by: Juan López Fernández <juanlopez@eprosima.com>
@juanlofer-eprosima
juanlofer-eprosima force-pushed the feature/limit-history-depth branch from 1d9680a to 3954701 Compare August 31, 2022 10:11
@juanlofer-eprosima
juanlofer-eprosima temporarily deployed to codecov August 31, 2022 10:11 Inactive
@juanlofer-eprosima
juanlofer-eprosima temporarily deployed to codecov August 31, 2022 10:11 Inactive

@MiguelBarro MiguelBarro left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now we have synchronous writers using KEEP_LAST and defaulting to 5000.
Remember to update the #287 in order to replace this default config with one matching the user writer.
LGTM

@juanlofer-eprosima
juanlofer-eprosima merged commit 45f8534 into main Aug 31, 2022
@juanlofer-eprosima
juanlofer-eprosima deleted the feature/limit-history-depth branch August 31, 2022 10:40
@juanlofer-eprosima juanlofer-eprosima changed the title Limit RTPS History Depth Limit RTPS History Depth [15534] Sep 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants