Fix creation of entities for TSAN issues [16073]#327
Merged
Conversation
Codecov ReportBase: 45.64% // Head: 45.75% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #327 +/- ##
==========================================
+ Coverage 45.64% 45.75% +0.11%
==========================================
Files 84 84
Lines 3374 3394 +20
Branches 1323 1326 +3
==========================================
+ Hits 1540 1553 +13
- Misses 1143 1148 +5
- Partials 691 693 +2
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
juanlofer-eprosima
requested changes
Nov 7, 2022
added 3 commits
November 11, 2022 09:59
Signed-off-by: jparisu <javierparis@eprosima.com>
Signed-off-by: jparisu <javierparis@eprosima.com>
Signed-off-by: jparisu <javierparis@eprosima.com>
1762cda to
743fa74
Compare
Signed-off-by: jparisu <javierparis@eprosima.com>
juanlofer-eprosima
requested changes
Nov 11, 2022
Signed-off-by: jparisu <javierparis@eprosima.com>
juanlofer-eprosima
approved these changes
Nov 14, 2022
Contributor
juanlofer-eprosima
left a comment
There was a problem hiding this comment.
LGTM, failing TSAN tests are due to middleware.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR requires a previous one: eProsima/dev-utils#14