Skip to content

Fix creation of entities for TSAN issues [16073]#327

Merged
jparisu merged 5 commits intomainfrom
fix/tsan-creation
Nov 14, 2022
Merged

Fix creation of entities for TSAN issues [16073]#327
jparisu merged 5 commits intomainfrom
fix/tsan-creation

Conversation

@jparisu
Copy link
Copy Markdown
Contributor

@jparisu jparisu commented Nov 4, 2022

This PR requires a previous one: eProsima/dev-utils#14

@jparisu jparisu temporarily deployed to codecov November 4, 2022 12:38 Inactive
@codecov
Copy link
Copy Markdown

codecov Bot commented Nov 4, 2022

Codecov Report

Base: 45.64% // Head: 45.75% // Increases project coverage by +0.11% 🎉

Coverage data is based on head (f30078b) compared to base (d541d85).
Patch coverage: 61.64% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #327      +/-   ##
==========================================
+ Coverage   45.64%   45.75%   +0.11%     
==========================================
  Files          84       84              
  Lines        3374     3394      +20     
  Branches     1323     1326       +3     
==========================================
+ Hits         1540     1553      +13     
- Misses       1143     1148       +5     
- Partials      691      693       +2     
Impacted Files Coverage Δ
...icipant/implementations/rtps/SimpleParticipant.cpp 75.00% <0.00%> (ø)
.../reader/implementations/rtps/SpecificQoSReader.cpp 0.00% <0.00%> (ø)
...rc/cpp/writer/implementations/rtps/MultiWriter.cpp 0.00% <0.00%> (ø)
.../writer/implementations/rtps/QoSSpecificWriter.cpp 0.00% <0.00%> (ø)
ddsrouter_core/src/cpp/core/ParticipantFactory.cpp 42.22% <50.00%> (-3.02%) ⬇️
...icipant/implementations/rtps/CommonParticipant.cpp 51.21% <60.00%> (-1.33%) ⬇️
...mplementations/rtps/DiscoveryServerParticipant.cpp 34.45% <66.66%> (ø)
...t/implementations/rtps/InitialPeersParticipant.cpp 38.79% <66.66%> (ø)
...c/cpp/reader/implementations/rtps/SimpleReader.cpp 83.33% <75.00%> (ø)
...c/cpp/reader/implementations/rtps/CommonReader.cpp 68.93% <84.61%> (+2.01%) ⬆️
... and 6 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@jparisu jparisu temporarily deployed to codecov November 10, 2022 06:38 Inactive
jparisu added 3 commits November 11, 2022 09:59
Signed-off-by: jparisu <javierparis@eprosima.com>
Signed-off-by: jparisu <javierparis@eprosima.com>
Signed-off-by: jparisu <javierparis@eprosima.com>
@jparisu jparisu temporarily deployed to codecov November 11, 2022 09:00 Inactive
Signed-off-by: jparisu <javierparis@eprosima.com>
@jparisu jparisu temporarily deployed to codecov November 11, 2022 09:00 Inactive
Comment thread ddsrouter_core/src/cpp/participant/implementations/rtps/CommonParticipant.cpp Outdated
Comment thread ddsrouter_core/src/cpp/reader/implementations/rtps/CommonReader.hpp
Signed-off-by: jparisu <javierparis@eprosima.com>
@jparisu jparisu temporarily deployed to codecov November 11, 2022 12:01 Inactive
Copy link
Copy Markdown
Contributor

@juanlofer-eprosima juanlofer-eprosima left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, failing TSAN tests are due to middleware.

@jparisu jparisu merged commit 6a88ba3 into main Nov 14, 2022
@jparisu jparisu deleted the fix/tsan-creation branch November 14, 2022 07:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants