Skip to content

Refactor Log Event Handler [16072]#14

Merged
jparisu merged 8 commits intomainfrom
refactor/LogEventHandler
Nov 11, 2022
Merged

Refactor Log Event Handler [16072]#14
jparisu merged 8 commits intomainfrom
refactor/LogEventHandler

Conversation

@jparisu
Copy link
Copy Markdown
Contributor

@jparisu jparisu commented Nov 2, 2022

No description provided.

@jparisu jparisu temporarily deployed to codecov November 2, 2022 11:58 Inactive
@jparisu jparisu temporarily deployed to codecov November 2, 2022 11:58 Inactive
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Nov 2, 2022

Codecov Report

❌ Patch coverage is 79.16667% with 5 lines in your changes missing coverage. Please review.
✅ Project coverage is 72.64%. Comparing base (c37323c) to head (7c2e4d7).
⚠️ Report is 105 commits behind head on main.

Files with missing lines Patch % Lines
...pp_utils/src/cpp/event/logging/LogEventHandler.cpp 66.66% 0 Missing and 3 partials ⚠️
...ls/src/cpp/event/logging/LogConsumerConnection.cpp 85.71% 0 Missing and 1 partial ⚠️
...ls/src/cpp/event/logging/LogConsumerConnection.hpp 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #14      +/-   ##
==========================================
+ Coverage   69.12%   72.64%   +3.51%     
==========================================
  Files          39       42       +3     
  Lines         732      742      +10     
  Branches      174      175       +1     
==========================================
+ Hits          506      539      +33     
+ Misses        140      106      -34     
- Partials       86       97      +11     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jparisu jparisu temporarily deployed to codecov November 2, 2022 12:21 Inactive
@jparisu jparisu temporarily deployed to codecov November 2, 2022 12:21 Inactive
@jparisu jparisu temporarily deployed to codecov November 2, 2022 12:54 Inactive
@jparisu jparisu temporarily deployed to codecov November 2, 2022 12:54 Inactive
Comment thread cpp_utils/include/cpp_utils/testing/LogChecker.hpp Outdated
Comment thread cpp_utils/src/cpp/event/logging/LogConsumerConnection.hpp
@jparisu jparisu changed the title Refactor Log Event Handler Refactor Log Event Handler [16072] Nov 3, 2022
@jparisu jparisu temporarily deployed to codecov November 3, 2022 16:12 Inactive
@jparisu jparisu temporarily deployed to codecov November 7, 2022 10:34 Inactive
@jparisu jparisu temporarily deployed to codecov November 7, 2022 10:34 Inactive
@jparisu jparisu temporarily deployed to codecov November 7, 2022 10:47 Inactive
@jparisu jparisu temporarily deployed to codecov November 7, 2022 10:47 Inactive
jparisu added 7 commits November 8, 2022 13:46
Signed-off-by: jparisu <javierparis@eprosima.com>
Signed-off-by: jparisu <javierparis@eprosima.com>
Signed-off-by: jparisu <javierparis@eprosima.com>
Signed-off-by: jparisu <javierparis@eprosima.com>
Signed-off-by: jparisu <javierparis@eprosima.com>
Signed-off-by: jparisu <javierparis@eprosima.com>
Signed-off-by: jparisu <javierparis@eprosima.com>
@jparisu jparisu force-pushed the refactor/LogEventHandler branch from d86015c to 2311f88 Compare November 8, 2022 12:47
@jparisu jparisu temporarily deployed to codecov November 8, 2022 12:47 Inactive
@jparisu jparisu temporarily deployed to codecov November 8, 2022 12:47 Inactive
Signed-off-by: jparisu <javierparis@eprosima.com>
@jparisu jparisu temporarily deployed to codecov November 11, 2022 08:42 Inactive
@jparisu jparisu temporarily deployed to codecov November 11, 2022 08:42 Inactive
Copy link
Copy Markdown
Contributor

@juanlofer-eprosima juanlofer-eprosima left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jparisu jparisu merged commit 96a49df into main Nov 11, 2022
@jparisu jparisu deleted the refactor/LogEventHandler branch November 11, 2022 08:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants