Skip to content

Refactor to use DDS Pipe v2#371

Merged
rsanchez15 merged 38 commits intomainfrom
refactor/ddspipe-v2
Jun 7, 2023
Merged

Refactor to use DDS Pipe v2#371
rsanchez15 merged 38 commits intomainfrom
refactor/ddspipe-v2

Conversation

@jparisu
Copy link
Copy Markdown
Contributor

@jparisu jparisu commented Apr 20, 2023 •
edited
Loading

Test branch to retake the refactor of DDS Router over DDS Pipe

Requirements

ToDo

  • Refactor blackbox tests to new api and namespaces

jparisu and others added 23 commits April 20, 2023 16:19
Refactor code
3c15103 
Signed-off-by: jparisu <javierparis@eprosima.com>
TMP first data received refactor
a00a9d9 
Signed-off-by: jparisu <javierparis@eprosima.com>
Add implementation to data received
5d6e4e9 
Signed-off-by: jparisu <javierparis@eprosima.com>
Data Received refactor with topic type id
51a7ed6 
Signed-off-by: jparisu <javierparis@eprosima.com>
Headers of the whole DDS Pipe and DDS Router
46780f1 
Signed-off-by: jparisu <javierparis@eprosima.com>
Implementation of src of ddspipe_core
9b0a180 
Signed-off-by: jparisu <javierparis@eprosima.com>
Implement participants srcs
14270dc 
Signed-off-by: jparisu <javierparis@eprosima.com>
Implement ddspipe_core tests
0871df8 
Signed-off-by: jparisu <javierparis@eprosima.com>
Implement ddspipe_yaml tests
cec3bde 
Signed-off-by: jparisu <javierparis@eprosima.com>
Implement tests (some)for ddsrouter_core
98c589c 
Signed-off-by: jparisu <javierparis@eprosima.com>
first refactor of ddsrouter yaml tests
b08c3d0 
Signed-off-by: jparisu <javierparis@eprosima.com>
@rsanchez15
Add ddsrouter_core implementation
bfbed90 
Signed-off-by: RaulSanchez <raul@eprosima.com>
@rsanchez15
Add ddsrouter_yaml source code
e29b355 
Signed-off-by: RaulSanchez <raul@eprosima.com>
All code compiling
5e2cc39 
Signed-off-by: jparisu <javierparis@eprosima.com>
Tool tests passing
068afb5 
Signed-off-by: jparisu <javierparis@eprosima.com>
Some fixes
381d419 
Signed-off-by: jparisu <javierparis@eprosima.com>
remove noexcept from default ctors
00f24f1 
Signed-off-by: jparisu <javierparis@eprosima.com>
Update github action
741c652 
Signed-off-by: jparisu <javierparis@eprosima.com>
Fixes
2308d1a 
Signed-off-by: jparisu <javierparis@eprosima.com>
add windows dlls
b9e5e4a 
Signed-off-by: jparisu <javierparis@eprosima.com>
remove ddspipe
d355b21 
Signed-off-by: jparisu <javierparis@eprosima.com>
update github actions
90037d1 
Signed-off-by: jparisu <javierparis@eprosima.com>
fix CI minor issues
fdcf20a 
Signed-off-by: jparisu <javierparis@eprosima.com>
@jparisu jparisu force-pushed the refactor/ddspipe-v2 branch from 3686694 to e073c90 Compare April 20, 2023 14:50
@jparisu jparisu temporarily deployed to codecov April 20, 2023 14:55 — with GitHub Actions Inactive
@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 20, 2023 •
edited
Loading

Codecov Report

Patch coverage: 49.10% and project coverage change: -16.93 ⚠️

Comparison is base (27b8489) 48.13% compared to head (8d7ed6b) 31.21%.

Additional details and impacted files 
@@             Coverage Diff             @@
##             main     #371       +/-   ##
===========================================
- Coverage   48.13%   31.21%   -16.93%     
===========================================
  Files          88       17       -71     
  Lines        3571      503     -3068     
  Branches     1348      250     -1098     
===========================================
- Hits         1719      157     -1562     
+ Misses       1151      197      -954     
+ Partials      701      149      -552
Impacted Files Coverage Δ
...dsrouter_core/configuration/SpecsConfiguration.hpp 100.00% <ø> (ø)
..._core/src/cpp/configuration/SpecsConfiguration.cpp 0.00% <ø> (ø)
...l/include/ddsrouter_yaml/testing/generate_yaml.hpp 50.00% <ø> (ø)
ddsrouter_yaml/src/cpp/YamlReaderConfiguration.cpp 39.28% <ø> (+2.44%) ⬆️
...dsrouter_yaml/src/cpp/YamlReader_configuration.cpp 37.31% <ø> (ø)
tools/ddsrouter_tool/src/cpp/main.cpp 17.94% <ø> (+2.15%) ⬆️
...src/cpp/user_interface/arguments_configuration.cpp 8.62% <ø> (+0.79%) ⬆️
ddsrouter_core/src/cpp/testing/random_values.cpp 41.17% <41.17%> (ø)
ddsrouter_core/src/cpp/core/ParticipantFactory.cpp 37.77% <45.45%> (-5.71%) ⬇️
ddsrouter_core/src/cpp/core/DdsRouter.cpp 46.26% <46.26%> (ø)
... and 6 more

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@jparisu jparisu temporarily deployed to codecov April 20, 2023 15:16 — with GitHub Actions Inactive
Update CI to eProsima v0
6266113 
Signed-off-by: jparisu <javierparis@eprosima.com>
@jparisu jparisu force-pushed the refactor/ddspipe-v2 branch from e80b28a to 6266113 Compare May 23, 2023 11:01
@jparisu jparisu temporarily deployed to codecov May 23, 2023 11:01 — with GitHub Actions Inactive
@jparisu jparisu temporarily deployed to codecov May 23, 2023 12:32 — with GitHub Actions Inactive
@jparisu jparisu temporarily deployed to codecov May 23, 2023 14:02 — with GitHub Actions Inactive
Add TSAN flags to tests
d1fe43d 
Signed-off-by: jparisu <javierparis@eprosima.com>
@jparisu jparisu force-pushed the refactor/ddspipe-v2 branch from 0acc573 to d1fe43d Compare May 23, 2023 14:04
@jparisu jparisu temporarily deployed to codecov May 23, 2023 14:04 — with GitHub Actions Inactive
rsanchez15
rsanchez15 requested changes May 24, 2023
View reviewed changes
Comment thread .dev/README.md
Comment thread .github/actions/project_dependencies/action.yml Outdated
Comment thread .github/actions/project_dependencies/action.yml Outdated
Comment thread .github/workflows/configurations/Linux/colcon.meta
Comment thread ddsrouter_core/include/ddsrouter_core/configuration/SpecsConfiguration.hpp Outdated
Comment thread ddsrouter_core/test/blackbox/ddsrouter_core/dds/local/DDSTestLocalDisposeKey.cpp
Comment thread ddsrouter_core/test/blackbox/implementations/CMakeLists.txt Outdated
Comment thread ddsrouter_yaml/README.md Outdated
Comment thread ddsrouter_yaml/test/unittest/CMakeLists.txt
add_subdirectory(yaml_tags)
add_subdirectory(yaml_manager)
add_subdirectory(yaml_reader)
# TODO uncomment when new API applied
Copy link
Copy Markdown
Collaborator

@rsanchez15 rsanchez15 May 24, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ddsrouter_yaml unittest are not updated to new API

Copy link
Copy Markdown
Collaborator

@rsanchez15 rsanchez15 May 29, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added in

Comment thread tools/ddsrouter_tool/package.xml
@rsanchez15
Copy link
Copy Markdown
Collaborator

rsanchez15 commented May 24, 2023

Missing Documentation (installation steps) update

fix uncrustify in github actions
c0e42cd 
Signed-off-by: jparisu <javierparis@eprosima.com>
@jparisu jparisu temporarily deployed to codecov May 26, 2023 08:34 — with GitHub Actions Inactive
@jparisu jparisu mentioned this pull request May 26, 2023
Merged
jparisu added 2 commits May 30, 2023 08:49
apply suggestions
36abaa1 
Signed-off-by: jparisu <javierparis@eprosima.com>
Add documentation
184bcdc 
Signed-off-by: jparisu <javierparis@eprosima.com>
@jparisu jparisu temporarily deployed to codecov May 30, 2023 07:04 — with GitHub Actions Inactive
rsanchez15
rsanchez15 requested changes Jun 1, 2023
View reviewed changes
Comment thread docs/rst/notes/forthcoming_version.rst Outdated
apply suggestions
29f79f1 
Signed-off-by: jparisu <javierparis@eprosima.com>
@jparisu jparisu temporarily deployed to codecov June 5, 2023 13:51 — with GitHub Actions Inactive
@jparisu jparisu temporarily deployed to codecov June 5, 2023 13:54 — with GitHub Actions Inactive
uncrustify
a428767 
Signed-off-by: jparisu <javierparis@eprosima.com>
@jparisu jparisu force-pushed the refactor/ddspipe-v2 branch from 88fdee3 to a428767 Compare June 5, 2023 14:00
@jparisu jparisu temporarily deployed to codecov June 5, 2023 14:00 — with GitHub Actions Inactive
Modify documentation regarding keys in topics
6f59654 
Signed-off-by: jparisu <javierparis@eprosima.com>
@jparisu jparisu temporarily deployed to codecov June 6, 2023 10:35 — with GitHub Actions Inactive
@rsanchez15
Refactor ddsrouter_yaml tests (#376)
8d7ed6b 
* Refactor ddsrouter_yaml tests

Signed-off-by: Raul Sanchez-Mateos <raul@eprosima.com>

* Apply suggested changes

Signed-off-by: Raul Sanchez-Mateos <raul@eprosima.com>

* Fix windows build

Signed-off-by: Raul Sanchez-Mateos <raul@eprosima.com>

---------

Signed-off-by: Raul Sanchez-Mateos <raul@eprosima.com>
@rsanchez15 rsanchez15 temporarily deployed to codecov June 6, 2023 14:58 — with GitHub Actions Inactive
rsanchez15
rsanchez15 approved these changes Jun 7, 2023
View reviewed changes
Copy link
Copy Markdown
Collaborator

@rsanchez15 rsanchez15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rsanchez15 rsanchez15 merged commit 4390ecb into main Jun 7, 2023
@rsanchez15 rsanchez15 deleted the refactor/ddspipe-v2 branch June 7, 2023 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rsanchez15 rsanchez15 rsanchez15 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jparisu @rsanchez15