Skip to content

Xml participant#377

Merged
rsanchez15 merged 12 commits intomainfrom
feature/xml-participant
Jun 23, 2023
Merged

Xml participant#377
rsanchez15 merged 12 commits intomainfrom
feature/xml-participant

Conversation

@jparisu
Copy link
Copy Markdown
Contributor

@jparisu jparisu commented May 26, 2023

@jparisu jparisu force-pushed the feature/xml-participant branch from b0fe6e3 to 4935953 Compare May 26, 2023 10:45
@jparisu jparisu force-pushed the feature/xml-participant branch from be8590f to ab98749 Compare June 9, 2023 07:46
@jparisu jparisu mentioned this pull request Jun 5, 2023
Merged
rsanchez15
rsanchez15 requested changes Jun 21, 2023
View reviewed changes
Comment thread ddsrouter_core/src/cpp/configuration/DdsRouterConfiguration.cpp Outdated
Comment thread ddsrouter_test/compose/test_cases/dds_rtps/compose.yml Outdated
Comment thread ddsrouter_test/compose/test_cases/dds_rtps/ddsrouter.yaml
Comment thread docs/rst/appendixes/glossary.rst Outdated
Comment thread docs/rst/notes/forthcoming_version.rst Outdated
Comment thread docs/rst/user_manual/participants/participant.rst Outdated
Comment thread docs/rst/user_manual/participants/xml.rst
Comment thread docs/rst/user_manual/participants/xml.rst Outdated
rsanchez15
rsanchez15 requested changes Jun 21, 2023
View reviewed changes
Copy link
Copy Markdown
Collaborator

@rsanchez15 rsanchez15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rebase and resolve conflicts

@juanlofer-eprosima juanlofer-eprosima mentioned this pull request Jun 21, 2023
Merged
rsanchez15
rsanchez15 requested changes Jun 21, 2023
View reviewed changes
Comment thread docs/rst/user_manual/participants/xml.rst Outdated
jparisu added 8 commits June 21, 2023 15:30
Implement new participant kind
4957654 
Signed-off-by: jparisu <javierparis@eprosima.com>
Add yaml impl
0a8b4db 
Signed-off-by: jparisu <javierparis@eprosima.com>
Implement tool for xml
2f28ec4 
Signed-off-by: jparisu <javierparis@eprosima.com>
logs and fixes
8567823 
Signed-off-by: jparisu <javierparis@eprosima.com>
Add tests
c6a08d7 
Signed-off-by: jparisu <javierparis@eprosima.com>
Some fixes to ddsrouter_test
3abc24c 
Signed-off-by: jparisu <javierparis@eprosima.com>
Documentation
da5a0d9 
Signed-off-by: jparisu <javierparis@eprosima.com>
apply suggestions
6792fdc 
Signed-off-by: jparisu <javierparis@eprosima.com>
@jparisu jparisu force-pushed the feature/xml-participant branch from 2db1ab4 to 6792fdc Compare June 21, 2023 13:31
jparisu
jparisu commented Jun 22, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor Author

@jparisu jparisu left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ToDo from PR eProsima/DDS-Pipe#41

  • Users should set ignore_local_endpoints
  • RPC support

Add documentation about limitations in pipe DDS participant
26449e6 
Signed-off-by: jparisu <javierparis@eprosima.com>
rsanchez15
rsanchez15 requested changes Jun 22, 2023
View reviewed changes
Comment thread docs/rst/user_manual/participants/xml.rst Outdated
Comment thread docs/rst/user_manual/participants/xml.rst Outdated
Comment thread docs/rst/user_manual/participants/xml.rst
apply small changes
3820a55 
Signed-off-by: jparisu <javierparis@eprosima.com>
@jparisu jparisu force-pushed the feature/xml-participant branch from 307ffbe to 3820a55 Compare June 22, 2023 10:03
@jparisu jparisu temporarily deployed to codecov June 22, 2023 12:03 — with GitHub Actions Inactive
@codecov
Copy link
Copy Markdown

codecov Bot commented Jun 22, 2023 •
edited
Loading

Codecov Report

Patch coverage: 35.13% and project coverage change: +0.79 🎉

Comparison is base (3dccba5) 31.21% compared to head (93e919e) 32.00%.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #377      +/-   ##
==========================================
+ Coverage   31.21%   32.00%   +0.79%     
==========================================
  Files          17       17              
  Lines         503      503              
  Branches      250      251       +1     
==========================================
+ Hits          157      161       +4     
+ Misses        197      187      -10     
- Partials      149      155       +6
Impacted Files Coverage Δ
...uter_core/configuration/DdsRouterConfiguration.hpp 100.00% <ø> (ø)
...e/include/ddsrouter_core/types/ParticipantKind.hpp 100.00% <ø> (ø)
...e/src/cpp/configuration/DdsRouterConfiguration.cpp 57.69% <0.00%> (+4.63%) ⬆️
ddsrouter_core/src/cpp/core/DdsRouter.cpp 46.26% <0.00%> (ø)
tools/ddsrouter_tool/src/cpp/main.cpp 17.72% <0.00%> (-0.23%) ⬇️
...dsrouter_yaml/src/cpp/YamlReader_configuration.cpp 36.48% <28.57%> (-0.83%) ⬇️
ddsrouter_core/src/cpp/core/ParticipantFactory.cpp 41.37% <36.84%> (+3.60%) ⬆️
ddsrouter_core/src/cpp/testing/random_values.cpp 43.58% <60.00%> (+2.41%) ⬆️
ddsrouter_yaml/src/cpp/YamlReaderConfiguration.cpp 39.28% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@jparisu jparisu temporarily deployed to codecov June 23, 2023 06:27 — with GitHub Actions Inactive
@jparisu jparisu force-pushed the feature/xml-participant branch from a3c9dd0 to df1bbd3 Compare June 23, 2023 07:10
@jparisu jparisu temporarily deployed to codecov June 23, 2023 07:10 — with GitHub Actions Inactive
Fix docker test dds test
06c63cf 
Signed-off-by: jparisu <javierparis@eprosima.com>
@jparisu jparisu force-pushed the feature/xml-participant branch from df1bbd3 to 06c63cf Compare June 23, 2023 07:30
@jparisu jparisu temporarily deployed to codecov June 23, 2023 07:30 — with GitHub Actions Inactive
uncrustify
93e919e 
Signed-off-by: jparisu <javierparis@eprosima.com>
@jparisu jparisu temporarily deployed to codecov June 23, 2023 08:09 — with GitHub Actions Inactive
@jparisu jparisu temporarily deployed to codecov June 23, 2023 08:58 — with GitHub Actions Inactive
@jparisu jparisu temporarily deployed to codecov June 23, 2023 09:18 — with GitHub Actions Inactive
@jparisu jparisu temporarily deployed to codecov June 23, 2023 10:10 — with GitHub Actions Inactive
@rsanchez15 rsanchez15 merged commit 09a040d into main Jun 23, 2023
@rsanchez15 rsanchez15 deleted the feature/xml-participant branch June 23, 2023 11:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rsanchez15 rsanchez15 rsanchez15 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jparisu @rsanchez15