You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
In serialize functions strlen is used. That makes impossible to serialize protobuf with null character in the messages. I propose to add function serialize(const char* string_t, int len).
Please read this comment. CDR specification clearly states that:
The string contents include a single terminating null character.
Hi JLBuenoLopez-eProsima
I don't think he's trying to express the meaning of the terminator. I understand that if the real data that the string needs to pass is 0, then Cdr will ignore this real data, resulting in meaningless passing
Then do not use a string type as the CDR specification does not allow to send a null character within the string content because it is not possible to differentiate between that character being data or the terminator. You can always define a sequence of octets and within that sequence you might set any number of null characters.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In serialize functions strlen is used. That makes impossible to serialize protobuf with null character in the messages. I propose to add function serialize(const char* string_t, int len).