Skip to content

Reset optional members when deserializing a PLAIN_CDR stream.#306

Merged
MiguelCompany merged 4 commits into
masterfrom
bugfix/plaincdr_optional
Jun 2, 2026
Merged

Reset optional members when deserializing a PLAIN_CDR stream.#306
MiguelCompany merged 4 commits into
masterfrom
bugfix/plaincdr_optional

Conversation

@richiware
Copy link
Copy Markdown
Member

@richiware richiware commented Apr 28, 2026 •
edited by MiguelCompany
Loading

Description

Reset optional members when deserializing a PLAIN_CDR stream.

@Mergifyio backport 2.2.x

Contributor Checklist

  • Commit messages follow the project guidelines.
  • The code follows the style guidelines of this project.
  • Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally
  • Any new/modified methods have been properly documented using Doxygen.
  • Changes are backport compatible: they do NOT break ABI nor change library core behavior.
  • Changes are API compatible.
  • New feature has been added to the versions.md file (if applicable).
  • Applicable backports have been included in the description.

Reviewer Checklist

  • The PR has a milestone assigned.
  • The title and description correctly express the PR's purpose.
  • Check contributor checklist is correct.
  • Check CI results: changes do not issue any warning.
  • Check CI results: CI pass and failing tests are unrelated with the changes.

@richiware
Add regression test
ab25f34 
Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev>
@richiware
Fix
b7e590c 
Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev>
@richiware richiware added this to the v2.3.6 milestone Apr 28, 2026
@richiware
Fix
f8838c7 
Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev>
@richiware richiware requested review from juanlofer-eprosima and removed request for juanlofer-eprosima April 28, 2026 08:55
MiguelCompany
MiguelCompany requested changes May 29, 2026
View reviewed changes
Comment thread include/fastcdr/Cdr.h
@MiguelCompany MiguelCompany removed the request for review from juanlofer-eprosima May 29, 2026 09:57
@richiware
Apply suggestions
ee4c577 
Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev>
@richiware richiware requested a review from MiguelCompany June 2, 2026 06:08
@MiguelCompany MiguelCompany merged commit d60f245 into master Jun 2, 2026
13 checks passed
@MiguelCompany MiguelCompany deleted the bugfix/plaincdr_optional branch June 2, 2026 07:18
@MiguelCompany
Copy link
Copy Markdown
Member

MiguelCompany commented Jun 2, 2026

@Mergifyio backport 2.2.x

@mergify
Copy link
Copy Markdown

mergify Bot commented Jun 2, 2026 •
edited
Loading

backport 2.2.x

✅ Backports have been created

Details

@mergify mergify Bot mentioned this pull request Jun 2, 2026
Merged
13 tasks
MiguelCompany pushed a commit that referenced this pull request Jun 2, 2026
@mergify @richiware
Reset optional members when deserializing a PLAIN_CDR stream (#306) (#…
9821b82 
…316)

* Add regression test



* Fix



* Fix



* Apply suggestions



---------


(cherry picked from commit d60f245)

Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev>
Co-authored-by: Ricardo González <ricardo@richiware.dev>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MiguelCompany MiguelCompany MiguelCompany approved these changes

Assignees

No one assigned

Labels

ci-pending

Projects

None yet

Milestone

v2.3.6 - Frozen ❄️

Development

Successfully merging this pull request may close these issues.

2 participants

@richiware @MiguelCompany