[24365] Fix UB in serialization methods#313
Merged
Merged
Conversation
Signed-off-by: Carlos Ferreira González <carlosferreira@eprosima.com>
12 tasks
Signed-off-by: Carlos Ferreira González <carlosferreira@eprosima.com>
Signed-off-by: Carlos Ferreira González <carlosferreira@eprosima.com>
Signed-off-by: Carlos Ferreira González <carlosferreira@eprosima.com>
Signed-off-by: Carlos Ferreira González <carlosferreira@eprosima.com>
MiguelCompany
approved these changes
May 19, 2026
Member
|
@Mergifyio backport 2.2.x |
✅ Backports have been createdDetails
|
8 tasks
MiguelCompany
pushed a commit
that referenced
this pull request
May 19, 2026
* Refs #24365: Fix UB in calculate_array_serialized_size * Refs #24365: Fix UB in serialize array * Refs #24365: Unrelated Uncrustify * Refs #24365: Revision * Refs #24365: Unrelated Uncrustify FastCdr.h --------- (cherry picked from commit a9bd70c) Signed-off-by: Carlos Ferreira González <carlosferreira@eprosima.com> Co-authored-by: Carlos Ferreira González <carlosferreira@eprosima.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes:
CdrSizeCalculator.hpp:1068:87: member call on null pointer of type 'const struct array'caused by an access todata->data()when size is 0.Cdr.h:2976:77: runtime error: member call on null pointer of type 'const struct array'caused by an access todata->data()when size is 0.Related PRs
Contributor Checklist
versions.mdfile (if applicable).Reviewer Checklist